Skip to content

Add support for serving via HTTPS #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

Add support for serving via HTTPS #25

wants to merge 13 commits into from

Conversation

tbell83
Copy link

@tbell83 tbell83 commented Mar 28, 2020

Support serving the code-server via HTTPS when passing in SSL_CERT and SSL_KEY, otherwise maintain current behavior.

linuxserver.io

Description:

Modify the run script to pass values from environment variables SSL_CERT and SSL_KEY to options --cert and --cert-key respectively, as per the man page:

  --cert                         Path to certificate. If the path is omitted,
                                 both this and --cert-key will be generated.
  --cert-key                     Path to the certificate's key if one was
                                 provided.

If both environment variables are not set, code-server will run HTTP, as is the current behavior.

Benefits of this PR and context:

Support serving via HTTPS.

How Has This Been Tested?

Run with both variables defined, code-server runs HTTPS
Run without both variables defined, code server runs HTTP

1 similar comment
@tbell83 tbell83 closed this Mar 28, 2020
@tbell83
Copy link
Author

tbell83 commented Mar 28, 2020

Dupes #23

@aborniak
Copy link

So , when this pull request will be merged into the master branch ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants