[CIR] LLVM lowering support for pointers to member functions #1292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We just went over a rebase against upstream, apologies for the churn but please update your branch for this PR and force-push! |
Lancern
force-pushed
the
member-func-ptr-lowering
branch
from
bfaa2cd to
5ea5c5c
Compare
|
Rebased onto the latest |
clang/lib/CIR/Dialect/Transforms/TargetLowering/ItaniumCXXABI.cpp
Outdated
Show resolved
Hide resolved
Lancern
force-pushed
the
member-func-ptr-lowering
branch
from
5ea5c5c to
4ee57cb
Compare
bcardosolopes
approved these changes
Feb 19, 2025
|
needs conflict fixing and ready to go |
This patch adds support for LLVM lowering of pointers to member functions. The lowering is ABI-specific and this patch only considers Itanium ABI. Itanium ABI lowers pointers to member functions to a struct with two fields of type `ptrdiff_t`. To extract fields from such aggregate values, this patch includes a new operation `cir.extract_member` to accomplish this.
Lancern
force-pushed
the
member-func-ptr-lowering
branch
from
4ee57cb to
b45eece
Compare
|
Rebased onto the latest |
|
All checks pass. Merging. |
lanza
pushed a commit
that referenced
this pull request
Mar 18, 2025
This PR adds support for LLVM lowering of pointers to member functions. The lowering is ABI-specific and this patch only considers Itanium ABI. Itanium ABI lowers pointers to member functions to a struct with two fields of type `ptrdiff_t`. To extract fields from such aggregate values, this PR includes a new operation `cir.extract_member` to accomplish this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for LLVM lowering of pointers to member functions. The lowering is ABI-specific and this patch only considers Itanium ABI.
Itanium ABI lowers pointers to member functions to a struct with two fields of type
ptrdiff_t. To extract fields from such aggregate values, this PR includes a new operationcir.extract_memberto accomplish this.