Skip to content

[CIR][CUDA] Fix CUDA CIR mangling bug #1396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2025
Merged

Conversation

advay168
Copy link
Contributor

Includes function name while mangling C functions to avoid link errors. This is the same way OG handles it.

@AdUhTkJm
Copy link
Contributor

The same issue didn't happen in simple.cu because it only emerges with extern "C". Sorry for not looking carefully enough for it.

@bcardosolopes bcardosolopes merged commit b5fb765 into llvm:main Feb 24, 2025
6 checks passed
lanza pushed a commit that referenced this pull request Mar 18, 2025
Includes function name while mangling C functions to avoid link errors.
[This is the same way OG handles
it](https://github.com/llvm/clangir/blob/c301b4a0d3d2d79b26c9c809c11b8a1137c0a9ec/clang/lib/CodeGen/CodeGenModule.cpp#L1896).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants