Skip to content

Commit 73fbe9c

Browse files
committed
add_tablegen: Remove LLVM_ENABLE_OBJLIB
- It doesn't work if `ALL_FILES` has `$<TARGET_OBJECTS>` with Makefile generator. - It was a micro-optimization in the ancient age. (introduced in rGe6bc093b42ff)
1 parent b73229e commit 73fbe9c

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

llvm/cmake/modules/TableGen.cmake

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -143,12 +143,6 @@ macro(add_tablegen target project)
143143
set(${target}_OLD_LLVM_LINK_COMPONENTS ${LLVM_LINK_COMPONENTS})
144144
set(LLVM_LINK_COMPONENTS ${LLVM_LINK_COMPONENTS} TableGen)
145145

146-
# CMake doesn't let compilation units depend on their dependent libraries on some generators.
147-
if(NOT CMAKE_GENERATOR MATCHES "Ninja" AND NOT XCODE)
148-
# FIXME: It leaks to user, callee of add_tablegen.
149-
set(LLVM_ENABLE_OBJLIB ON)
150-
endif()
151-
152146
add_llvm_executable(${target} DISABLE_LLVM_LINK_LLVM_DYLIB
153147
${ADD_TABLEGEN_UNPARSED_ARGUMENTS})
154148
set(LLVM_LINK_COMPONENTS ${${target}_OLD_LLVM_LINK_COMPONENTS})

0 commit comments

Comments
 (0)