Skip to content

Commit a6dcd48

Browse files
committed
Address review feedback
1 parent f7d3ae1 commit a6dcd48

4 files changed

+13
-15
lines changed

lld/test/ELF/aarch64-call26-thunk-execute-only.s

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,10 @@ _start:
1111
// CHECK: Disassembly of section .text:
1212
// CHECK-EMPTY:
1313
// CHECK-LABEL: <_start>:
14-
// CHECK-NEXT: 210120: bl 0x210124
14+
// CHECK-NEXT: bl {{.*}} <__AArch64AbsXOLongThunk_big>
1515
// CHECK-LABEL: <__AArch64AbsXOLongThunk_big>:
16-
// CHECK-NEXT: 210124: mov x16, #0x4444
17-
// CHECK-NEXT: movk x16, #0x3333, lsl #16
18-
// CHECK-NEXT: movk x16, #0x2222, lsl #32
19-
// CHECK-NEXT: movk x16, #0x1111, lsl #48
20-
// CHECK-NEXT: br x16
21-
16+
// CHECK-NEXT: mov x16, #0x4444
17+
// CHECK-NEXT: movk x16, #0x3333, lsl #16
18+
// CHECK-NEXT: movk x16, #0x2222, lsl #32
19+
// CHECK-NEXT: movk x16, #0x1111, lsl #48
20+
// CHECK-NEXT: br x16

lld/test/ELF/aarch64-execute-only.s

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,11 @@
11
// REQUIRES: aarch64
22

3-
// RUN: llvm-mc -filetype=obj -triple=aarch64-linux-none %s -o %t.o
3+
// RUN: llvm-mc -filetype=obj -triple=aarch64 %s -o %t.o
44
// RUN: ld.lld %t.o -o %t.so -shared
55
// RUN: llvm-readelf -l %t.so | FileCheck --implicit-check-not=LOAD %s
66

7-
// RUN: echo ".section .foo,\"ax\"; \
8-
// RUN: ret" > %t.s
9-
// RUN: llvm-mc -filetype=obj -triple=aarch64-linux-none %t.s -o %t2.o
7+
// RUN: echo ".section .foo,\"ax\"; ret" > %t.s
8+
// RUN: llvm-mc -filetype=obj -triple=aarch64 %t.s -o %t2.o
109
// RUN: ld.lld %t.o %t2.o -o %t.so -shared
1110
// RUN: llvm-readelf -l %t.so | FileCheck --check-prefix=DIFF --implicit-check-not=LOAD %s
1211

lld/test/ELF/aarch64-jump26-thunk-execute-only.s

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,10 @@ _start:
1111
// CHECK: Disassembly of section .text:
1212
// CHECK-EMPTY:
1313
// CHECK-LABEL: <_start>:
14-
// CHECK-NEXT: 210120: b 0x210124
14+
// CHECK-NEXT: b {{.*}} <__AArch64AbsXOLongThunk_big>
1515
// CHECK-LABEL: <__AArch64AbsXOLongThunk_big>:
16-
// CHECK-NEXT: 210124: mov x16, #0x4444
16+
// CHECK-NEXT: mov x16, #0x4444
1717
// CHECK-NEXT: movk x16, #0x3333, lsl #16
1818
// CHECK-NEXT: movk x16, #0x2222, lsl #32
1919
// CHECK-NEXT: movk x16, #0x1111, lsl #48
2020
// CHECK-NEXT: br x16
21-

lld/test/ELF/input-section-flags.s

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@
1515
# RUN: .outsec3 : { INPUT_SECTION_FLAGS(SHF_WRITE) *(.sec.*) } \
1616
# RUN: .outsec4 : { INPUT_SECTION_FLAGS(SHF_MERGE & !SHF_STRINGS) *(.sec.*) } \
1717
# RUN: .outsec5 : { INPUT_SECTION_FLAGS(SHF_STRINGS) *(.sec.*) } \
18-
# RUN: .outsec6 : { INPUT_SECTION_FLAGS(!SHF_TLS & !SHF_EXCLUDE & !SHF_COMPRESSED & !SHF_ARM_PURECODE) *(.sec.*) } \
18+
# RUN: .outsec6 : { INPUT_SECTION_FLAGS(!SHF_TLS & !SHF_EXCLUDE & !SHF_COMPRESSED & \
19+
# RUN: !SHF_ARM_PURECODE & !SHF_AARCH64_PURECODE) *(.sec.*) } \
1920
# RUN: } " > %t.script
2021
# RUN: ld.lld -o %t1 --script %t.script %t.o
2122
# RUN: llvm-readobj --symbols %t1 | FileCheck %s

0 commit comments

Comments
 (0)