Skip to content

Commit daa1e17

Browse files
authored
[lldb-dap] Make lldb-dap.executable-path machine specific (#137485)
Change the scope [1] of lldb-dap.executable-path to "machine-overridable": > Machine specific settings that can be overridden by workspace or > folder settings. Practically speaking, this means that the path won't be synced across machines and "(Not synced)" will show up next to the setting. I believe it doesn't make sense to sync this setting (and I remember a bug report where this caused trouble when using VS Code remotely), plus it matches what clangd does for its corresponding setting. The extension has logic to find the binary in your path or with `xcrun` which in most cases should do the right thing and prevent you from having to override this setting. [1] https://code.visualstudio.com/api/references/contribution-points#Configuration-property-schema
1 parent 7904298 commit daa1e17

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

lldb/tools/lldb-dap/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,8 @@
7474
"lldb-dap.executable-path": {
7575
"scope": "resource",
7676
"type": "string",
77-
"description": "The path to the lldb-dap binary."
77+
"scope": "machine-overridable",
78+
"description": "The path to the lldb-dap binary, e.g. /usr/local/bin/lldb-dap"
7879
},
7980
"lldb-dap.arguments": {
8081
"scope": "resource",

0 commit comments

Comments
 (0)