[lldb-dap] Make lldb-dap.executable-path machine specific #137485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the scope [1] of lldb-dap.executable-path to "machine-overridable": > Machine specific settings that can be overridden by workspace or > folder settings. Practically speaking, this means that the path won't be synced across machines and "(Not synced)" will show up next to the setting. I believe it doesn't make sense to sync this setting (and I remember a bug report where this caused trouble when using VS Code remotely), plus it matches what clangd does for its corresponding setting. [1] https://code.visualstudio.com/api/references/contribution-points#Configuration-property-schema
|
Here's what this looks like in the UI: 
|
|
@llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) ChangesChange the scope [1] of lldb-dap.executable-path to "machine-overridable": > Machine specific settings that can be overridden by workspace or Practically speaking, this means that the path won't be synced across machines and "(Not synced)" will show up next to the setting. I believe it doesn't make sense to sync this setting (and I remember a bug report where this caused trouble when using VS Code remotely), plus it matches what clangd does for its corresponding setting. [1] https://code.visualstudio.com/api/references/contribution-points#Configuration-property-schema Full diff: https://github.com/llvm/llvm-project/pull/137485.diff 1 Files Affected:
diff --git a/lldb/tools/lldb-dap/package.json b/lldb/tools/lldb-dap/package.json
index 3957e3f27f297..c25d5033d09f1 100644
--- a/lldb/tools/lldb-dap/package.json
+++ b/lldb/tools/lldb-dap/package.json
@@ -74,7 +74,8 @@
"lldb-dap.executable-path": {
"scope": "resource",
"type": "string",
- "description": "The path to the lldb-dap binary."
+ "scope": "machine-overridable",
+ "description": "The path to the lldb-dap binary, e.g. /usr/local/bin/lldb-dap"
},
"lldb-dap.arguments": {
"scope": "resource",
|
da-viper
approved these changes
Apr 27, 2025
ashgti
approved these changes
Apr 27, 2025
jyli0116
pushed a commit
to jyli0116/llvm-project
that referenced
this pull request
Apr 28, 2025
Change the scope [1] of lldb-dap.executable-path to "machine-overridable": > Machine specific settings that can be overridden by workspace or > folder settings. Practically speaking, this means that the path won't be synced across machines and "(Not synced)" will show up next to the setting. I believe it doesn't make sense to sync this setting (and I remember a bug report where this caused trouble when using VS Code remotely), plus it matches what clangd does for its corresponding setting. The extension has logic to find the binary in your path or with `xcrun` which in most cases should do the right thing and prevent you from having to override this setting. [1] https://code.visualstudio.com/api/references/contribution-points#Configuration-property-schema
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
Change the scope [1] of lldb-dap.executable-path to "machine-overridable": > Machine specific settings that can be overridden by workspace or > folder settings. Practically speaking, this means that the path won't be synced across machines and "(Not synced)" will show up next to the setting. I believe it doesn't make sense to sync this setting (and I remember a bug report where this caused trouble when using VS Code remotely), plus it matches what clangd does for its corresponding setting. The extension has logic to find the binary in your path or with `xcrun` which in most cases should do the right thing and prevent you from having to override this setting. [1] https://code.visualstudio.com/api/references/contribution-points#Configuration-property-schema
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
Change the scope [1] of lldb-dap.executable-path to "machine-overridable": > Machine specific settings that can be overridden by workspace or > folder settings. Practically speaking, this means that the path won't be synced across machines and "(Not synced)" will show up next to the setting. I believe it doesn't make sense to sync this setting (and I remember a bug report where this caused trouble when using VS Code remotely), plus it matches what clangd does for its corresponding setting. The extension has logic to find the binary in your path or with `xcrun` which in most cases should do the right thing and prevent you from having to override this setting. [1] https://code.visualstudio.com/api/references/contribution-points#Configuration-property-schema
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
Change the scope [1] of lldb-dap.executable-path to "machine-overridable": > Machine specific settings that can be overridden by workspace or > folder settings. Practically speaking, this means that the path won't be synced across machines and "(Not synced)" will show up next to the setting. I believe it doesn't make sense to sync this setting (and I remember a bug report where this caused trouble when using VS Code remotely), plus it matches what clangd does for its corresponding setting. The extension has logic to find the binary in your path or with `xcrun` which in most cases should do the right thing and prevent you from having to override this setting. [1] https://code.visualstudio.com/api/references/contribution-points#Configuration-property-schema
Ankur-0429
pushed a commit
to Ankur-0429/llvm-project
that referenced
this pull request
May 9, 2025
Change the scope [1] of lldb-dap.executable-path to "machine-overridable": > Machine specific settings that can be overridden by workspace or > folder settings. Practically speaking, this means that the path won't be synced across machines and "(Not synced)" will show up next to the setting. I believe it doesn't make sense to sync this setting (and I remember a bug report where this caused trouble when using VS Code remotely), plus it matches what clangd does for its corresponding setting. The extension has logic to find the binary in your path or with `xcrun` which in most cases should do the right thing and prevent you from having to override this setting. [1] https://code.visualstudio.com/api/references/contribution-points#Configuration-property-schema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the scope [1] of lldb-dap.executable-path to "machine-overridable":
Practically speaking, this means that the path won't be synced across machines and "(Not synced)" will show up next to the setting. I believe it doesn't make sense to sync this setting (and I remember a bug report where this caused trouble when using VS Code remotely), plus it matches what clangd does for its corresponding setting. The extension has logic to find the binary in your path or with
xcrunwhich in most cases should do the right thing and prevent you from having to override this setting.[1] https://code.visualstudio.com/api/references/contribution-points#Configuration-property-schema