[Driver] Simplify string comparisons (NFC) (#137756)

kazutakahirata · web-flow · commit ff66d34286b0 · 2025-04-29T00:30:59.000-07:00
diff --git a/clang/lib/Driver/ToolChains/Flang.cpp b/clang/lib/Driver/ToolChains/Flang.cpp
@@ -159,7 +159,7 @@ void Flang::addCodegenOptions(const ArgList &Args,
 
   for (const auto &arg :
        Args.getAllArgValues(options::OPT_frepack_arrays_contiguity_EQ))
-    if (arg.compare("whole") != 0 && arg.compare("innermost") != 0) {
+    if (arg != "whole" && arg != "innermost") {
       getToolChain().getDriver().Diag(diag::err_drv_unsupported_option_argument)
           << "-frepack-arrays-contiguity=" << arg;
     }

Original file line number	Diff line number	Diff line change
`@@ -159,7 +159,7 @@ void Flang::addCodegenOptions(const ArgList &Args,`
`159`	`159`
`160`	`160`	`for (const auto &arg :`
`161`	`161`	`Args.getAllArgValues(options::OPT_frepack_arrays_contiguity_EQ))`
`162`		`- if (arg.compare("whole") != 0 && arg.compare("innermost") != 0) {`
	`162`	`+ if (arg != "whole" && arg != "innermost") {`
`163`	`163`	`getToolChain().getDriver().Diag(diag::err_drv_unsupported_option_argument)`
`164`	`164`	`<< "-frepack-arrays-contiguity=" << arg;`
`165`	`165`	`}`