-
Notifications
You must be signed in to change notification settings - Fork 13.5k
[Driver] Simplify string comparisons (NFC) #137756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kazutakahirata
merged 1 commit into
llvm:main
from
kazutakahirata:cleanup_001_string_compare_clang
Apr 29, 2025
Merged
[Driver] Simplify string comparisons (NFC) #137756
kazutakahirata
merged 1 commit into
llvm:main
from
kazutakahirata:cleanup_001_string_compare_clang
Apr 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@llvm/pr-subscribers-clang-driver Author: Kazu Hirata (kazutakahirata) ChangesFull diff: https://github.com/llvm/llvm-project/pull/137756.diff 1 Files Affected:
diff --git a/clang/lib/Driver/ToolChains/Flang.cpp b/clang/lib/Driver/ToolChains/Flang.cpp
index a8b4688aed09c..e9d5a844ab073 100644
--- a/clang/lib/Driver/ToolChains/Flang.cpp
+++ b/clang/lib/Driver/ToolChains/Flang.cpp
@@ -159,7 +159,7 @@ void Flang::addCodegenOptions(const ArgList &Args,
for (const auto &arg :
Args.getAllArgValues(options::OPT_frepack_arrays_contiguity_EQ))
- if (arg.compare("whole") != 0 && arg.compare("innermost") != 0) {
+ if (arg != "whole" && arg != "innermost") {
getToolChain().getDriver().Diag(diag::err_drv_unsupported_option_argument)
<< "-frepack-arrays-contiguity=" << arg;
}
|
@llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) ChangesFull diff: https://github.com/llvm/llvm-project/pull/137756.diff 1 Files Affected:
diff --git a/clang/lib/Driver/ToolChains/Flang.cpp b/clang/lib/Driver/ToolChains/Flang.cpp
index a8b4688aed09c..e9d5a844ab073 100644
--- a/clang/lib/Driver/ToolChains/Flang.cpp
+++ b/clang/lib/Driver/ToolChains/Flang.cpp
@@ -159,7 +159,7 @@ void Flang::addCodegenOptions(const ArgList &Args,
for (const auto &arg :
Args.getAllArgValues(options::OPT_frepack_arrays_contiguity_EQ))
- if (arg.compare("whole") != 0 && arg.compare("innermost") != 0) {
+ if (arg != "whole" && arg != "innermost") {
getToolChain().getDriver().Diag(diag::err_drv_unsupported_option_argument)
<< "-frepack-arrays-contiguity=" << arg;
}
|
nikic
approved these changes
Apr 29, 2025
gizmondo
pushed a commit
to gizmondo/llvm-project
that referenced
this pull request
Apr 29, 2025
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
GeorgeARM
pushed a commit
to GeorgeARM/llvm-project
that referenced
this pull request
May 7, 2025
Ankur-0429
pushed a commit
to Ankur-0429/llvm-project
that referenced
this pull request
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
clang:driver
'clang' and 'clang++' user-facing binaries. Not 'clang-cl'
clang
Clang issues not falling into any other category
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.