Cannot change boolean variable with lldb-dap

[JDevlieghere]

To change the value of a boolean variable, lldb-dap rejects true and false and makes you use 0 and 1.

Using false:

{"command":"setVariable","arguments":{"variablesReference":24,"name":"m_is_file","value":"false"},"type":"request","seq":27}
{"body":{"message":"'false' is not a valid integer string value"},"command":"setVariable","request_seq":27,"seq":0,"success":false,"type":"response"}

Use 1:

{"command":"setVariable","arguments":{"variablesReference":24,"name":"m_is_file","value":"1"},"type":"request","seq":30}
{"body":{"type":"bool","value":"true","variablesReference":0},"command":"setVariable","request_seq":30,"seq":0,"success":true,"type":"response"}

I'm not sure if this is really an lldb-dap issue or SBValue::SetValueFromCString doing the wrong thing.

[llvmbot]

@llvm/issue-subscribers-lldb

Author: Jonas Devlieghere (JDevlieghere)

To change the value of a boolean variable, lldb-dap rejects `true` and `false` and makes you use `0` and `1`.

Using false:

{"command":"setVariable","arguments":{"variablesReference":24,"name":"m_is_file","value":"false"},"type":"request","seq":27}
{"body":{"message":"'false' is not a valid integer string value"},"command":"setVariable","request_seq":27,"seq":0,"success":false,"type":"response"}

Use 1:

{"command":"setVariable","arguments":{"variablesReference":24,"name":"m_is_file","value":"1"},"type":"request","seq":30}
{"body":{"type":"bool","value":"true","variablesReference":0},"command":"setVariable","request_seq":30,"seq":0,"success":true,"type":"response"}

I'm not sure if this is really an lldb-dap issue or SBValue::SetValueFromCString doing the wrong thing.