Skip to content

[clang-include-cleaner] suggest to insert header in source file when header would be enough #122847

Open
@EugeneZelenko

Description

@EugeneZelenko

clang-include-cleaner suggest to include cstddef because of constructor (or may be method) implementation when it its inclusion in header should be enough.

clang-tidy misc-include-cleaner output:

clang-tidy -checks="-*,misc-include-cleaner" Method.cpp 
1 warning generated.
Method.cpp:3:18: warning: no header providing "size_t" is directly included [misc-include-cleaner]
    2 | 
    3 | Test::Test(const size_t size)
      |                  ^

I tried clang-include-cleaner from main (7d8b4eb).

Header file (Method.h):

#pragma once

#include <cstddef>

class Test
{
public:
    Test(const size_t size);

protected:
    size_t size_;
};

Source file (Method.cpp):

#include "Method.h"

Test::Test(const size_t size)
:   size_(size)
{
}

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions