[MLIR][tensor::ExtractSliceOp] Extract slice verification invalid

[hockyy]

    // Last element is 2044 from extracted_slice
    // extracted_slice is banished
    // ??
    // [.. 2044 2045 2046] [0] [0 1 2 3 4 5 6 ...]
    //     0    1    2      3   4 5 6 7 8 0
    // Next offset should be 5
    // Ends at 743 (last one, so arg2 size should at least be 744)

%concat = tensor.concat dim(1) %arg1, %extracted_slice, %arg2 : (tensor<8x2047x9xi32>, tensor<8x1x9xi32>, tensor<8x743x9xi32>) -> tensor<8x2791x9xi32>
    %extracted_slice_0 = tensor.extract_slice %concat[3, 100, 0] [2, 300, 2] [2, 9, 3] : tensor<8x2791x9xi32> to tensor<2x300x2xi32>

Why is this not verified?

[llvmbot]

@llvm/issue-subscribers-mlir

Author: Hocky Yudhiono (hockyy)

```

// Last element is 2044 from extracted_slice
// extracted_slice is banished
// ??
// [.. 2044 2045 2046] [0] [0 1 2 3 4 5 6 ...]
//     0    1    2      3   4 5 6 7 8 0
// Next offset should be 5
// Ends at 743 (last one, so arg2 size should at least be 744)

%concat = tensor.concat dim(1) %arg1, %extracted_slice, %arg2 : (tensor<8x2047x9xi32>, tensor<8x1x9xi32>, tensor<8x743x9xi32>) -> tensor<8x2791x9xi32>
%extracted_slice_0 = tensor.extract_slice %concat[3, 100, 0] [2, 300, 2] [2, 9, 3] : tensor<8x2791x9xi32> to tensor<2x300x2xi32>

Why is this not verified?

</details>

[CoTinker]

I might be misunderstanding something, but this case works.

module {
  func.func @extract(%arg0: tensor<8x2791x9xi32>) -> tensor<2x300x2xi32> {
    %extracted_slice = tensor.extract_slice %arg0[3, 100, 0] [2, 300, 2] [2, 9, 3] : tensor<8x2791x9xi32> to tensor<2x300x2xi32>
    return %extracted_slice : tensor<2x300x2xi32>
  }
}

[hockyy]

I might be misunderstanding something, but this case works.

module {
  func.func @extract(%arg0: tensor<8x2791x9xi32>) -> tensor<2x300x2xi32> {
    %extracted_slice = tensor.extract_slice %arg0[3, 100, 0] [2, 300, 2] [2, 9, 3] : tensor<8x2791x9xi32> to tensor<2x300x2xi32>
    return %extracted_slice : tensor<2x300x2xi32>
  }
}

Last element is at 2791, which is overflow

[hockyy]

maybe extract slice doesnt add this check