Missed optimization: (%1 <= ~%0) && (%0 > ~%1) ==> false

[GINN-Imp]

The following reduced IR is derived from https://github.com/Cisco-Talos/clamav/blob/6c508107355bca613ffe7b0d2a4deb7636940a87/libclamav/pe.c#L2765

Godbolt: https://godbolt.org/z/d441Gcjdr
alive2 proof: https://alive2.llvm.org/ce/z/7BfGRs

define i1 @src(i32 %0, i32 %1) local_unnamed_addr #0 {
common.ret:
  %2 = xor i32 %0, -1
  %3 = icmp ule i32 %1, %2
  %4 = xor i32 %1, -1
  %5 = icmp ugt i32 %0, %4
  %common.ret.op = and i1 %3, %5
  ret i1 %common.ret.op
}

expected:

define noundef i1 @tgt(i32 %0, i32 %1) local_unnamed_addr #0 {
common.ret:
  ret i1 false
}

opt-trunk -O3 generates:

define i1 @src(i32 %0, i32 %1) local_unnamed_addr #0 {
common.ret:
  %2 = xor i32 %0, -1
  %3 = icmp ule i32 %1, %2
  %4 = xor i32 %1, -1
  %5 = icmp ugt i32 %0, %4
  %common.ret.op = and i1 %3, %5
  ret i1 %common.ret.op
}

[dtcxzyw]

Both LHS and RHS are uadd-overflow check idiom: https://alive2.llvm.org/ce/z/VEWFs7

[llvmbot]

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

1. Check that no other contributor has already been assigned to this issue. If you believe that no one is actually working on it despite an assignment, ping the person. After one week without a response, the assignee may be changed.
2. In the comments of this issue, request for it to be assigned to you, or just create a pull request after following the steps below. Mention this issue in the description of the pull request.
3. Fix the issue locally.
4. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
5. Create a Git commit.
6. Run git clang-format HEAD~1 to format your changes.
7. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation. Mention this issue in the description of the pull request.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

[llvmbot]

@llvm/issue-subscribers-good-first-issue

Author: None (GINN-Imp)

The following reduced IR is derived from https://github.com/Cisco-Talos/clamav/blob/6c508107355bca613ffe7b0d2a4deb7636940a87/libclamav/pe.c#L2765

Godbolt: https://godbolt.org/z/d441Gcjdr
alive2 proof: https://alive2.llvm.org/ce/z/7BfGRs

define i1 @<!-- -->src(i32 %0, i32 %1) local_unnamed_addr #<!-- -->0 {
common.ret:
  %2 = xor i32 %0, -1
  %3 = icmp ule i32 %1, %2
  %4 = xor i32 %1, -1
  %5 = icmp ugt i32 %0, %4
  %common.ret.op = and i1 %3, %5
  ret i1 %common.ret.op
}

expected:

define noundef i1 @<!-- -->tgt(i32 %0, i32 %1) local_unnamed_addr #<!-- -->0 {
common.ret:
  ret i1 false
}

opt-trunk -O3 generates:

define i1 @<!-- -->src(i32 %0, i32 %1) local_unnamed_addr #<!-- -->0 {
common.ret:
  %2 = xor i32 %0, -1
  %3 = icmp ule i32 %1, %2
  %4 = xor i32 %1, -1
  %5 = icmp ugt i32 %0, %4
  %common.ret.op = and i1 %3, %5
  ret i1 %common.ret.op
}

[bobby-b-song]

I can try implementing this under instcombine, if that's what's suggested.