Crush with referencing non-static constexpr string.

[DenisYaroshevskiy]

Bugzilla Link	37736
Version	trunk
OS	All
CC	@DougGregor

Extended Description

Hi!

We recently got a crush, that boils can be fixed by marking constexpr char[] as static.
If we check this in clang 6.0 - the codegen is identical for both static and non-static. It's not the case in trunk.

Here's godbolt: https://godbolt.org/g/R4WhUQ

Best,
Denis

[DenisYaroshevskiy]

I asked around, and this is not a bug.
The codegen is weird though. Maybe some diagnostics?)

[cor3ntin]

Adding a diagnostics in this scenario is akin to implement a borrow checker. So I will close this
Note that asan helps https://gcc.godbolt.org/z/KG5Gbz676
We can also diagnose if the variable is returned directly (without the string_view conversion)