Skip to content

Minimum CMake version is too low #54099

Closed
@Kobzol

Description

@Kobzol

The minimum supported CMake version is currently set to 3.13.4 (https://github.com/llvm/llvm-project/blob/main/llvm/CMakeLists.txt#L3). However, the bolt subproject uses the TYPE parameter for the install command (https://github.com/llvm/llvm-project/blob/main/bolt/tools/driver/CMakeLists.txt#L38), which does not seem to work in this version. It seems that the minimum CMake version should be bumped to 3.14.0.

CMake 3.13: https://cmake.org/cmake/help/v3.13/command/install.html#programs (TYPE is missing)
CMake 3.14: https://cmake.org/cmake/help/v3.14/command/install.html#programs (TYPE is present)

I hit this while trying to build BOLT with LLVM 3.13.4 in a rustc CI workflow.

This has also been noticed in other projects: https://github.com/coelckers/prboom-plus/pull/126/files.

Metadata

Metadata

Assignees

No one assigned

    Labels

    BOLTcmakeBuild system in general and CMake in particular

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions