[SPIR-V] LIT tests with -opaque-pointers=0

[michalpaszkowski]

The following SPIR-V backend LIT tests are run with -opaque-pointers=0 and still require changes:

• CodeGen/SPIRV/EnqueueEmptyKernel.ll
• CodeGen/SPIRV/SampledImageRetType.ll
• CodeGen/SPIRV/atomicrmw.ll
• CodeGen/SPIRV/constant/global-constants.ll
• CodeGen/SPIRV/constant/local-null-constants.ll
• CodeGen/SPIRV/function/alloca-load-store.ll
• CodeGen/SPIRV/half_extension.ll
• CodeGen/SPIRV/half_no_extension.ll
• CodeGen/SPIRV/image-unoptimized.ll
• CodeGen/SPIRV/image.ll
• CodeGen/SPIRV/image_decl_func_arg.ll
• CodeGen/SPIRV/image_dim.ll
• CodeGen/SPIRV/image_store.ll
• CodeGen/SPIRV/link-attribute.ll
• CodeGen/SPIRV/linked-list.ll
• CodeGen/SPIRV/literal-struct.ll
• CodeGen/SPIRV/llvm-intrinsics/memset.ll
• CodeGen/SPIRV/llvm-intrinsics/sqrt.ll
• CodeGen/SPIRV/opencl.queue_t.ll
• CodeGen/SPIRV/opencl/basic/get_global_offset.ll
• CodeGen/SPIRV/opencl/basic/progvar_prog_scope_init.ll
• CodeGen/SPIRV/opencl/basic/vstore_private.ll
• CodeGen/SPIRV/opencl/image.ll
• CodeGen/SPIRV/pstruct.ll
• CodeGen/SPIRV/read_image.ll
• CodeGen/SPIRV/spirv.Queue.ll
• CodeGen/SPIRV/struct.ll
• CodeGen/SPIRV/transcoding/BuildNDRange_2.ll
• CodeGen/SPIRV/transcoding/OpConstantSampler.ll
• CodeGen/SPIRV/transcoding/OpImageQuerySize.ll
• CodeGen/SPIRV/transcoding/OpImageReadMS.ll
• CodeGen/SPIRV/transcoding/OpImageSampleExplicitLod.ll
• CodeGen/SPIRV/transcoding/OpImageWrite.ll
• CodeGen/SPIRV/transcoding/OpenCL/atomic_cmpxchg.ll
• CodeGen/SPIRV/transcoding/OpenCL/atomic_legacy.ll
• CodeGen/SPIRV/transcoding/SampledImage.ll
• CodeGen/SPIRV/transcoding/block_w_struct_return.ll
• CodeGen/SPIRV/transcoding/check_ro_qualifier.ll
• CodeGen/SPIRV/transcoding/cl-types.ll
• CodeGen/SPIRV/transcoding/clk_event_t.ll
• CodeGen/SPIRV/transcoding/enqueue_kernel.ll
• CodeGen/SPIRV/transcoding/extract_insert_value.ll
• CodeGen/SPIRV/transcoding/get_image_num_mip_levels.ll
• CodeGen/SPIRV/transcoding/global_block.ll
• CodeGen/SPIRV/transcoding/image_get_size_with_access_qualifiers.ll
• CodeGen/SPIRV/transcoding/image_with_access_qualifiers.ll
• CodeGen/SPIRV/transcoding/optional-core-features-multiple.ll
• CodeGen/SPIRV/transcoding/spec_const.ll
• CodeGen/SPIRV/transcoding/spirv-private-array-initialization.ll
• CodeGen/SPIRV/transcoding/spirv-types.ll

[llvmbot]

@llvm/issue-subscribers-opencl

[nikic]

Just a friendly reminder that this still needs to be done.

[nikic]

Another small reminder. The option on the clang side has already been dropped, and the same will happen on the LLVM side soon.

[nikic]

FYI support for -opaque-pointers=0 has been removed.

[MaskRay]

@iliya-diyachkov @michalpaszkowski With the removal of the -opaque-pointer option, many llvm/test/CodeGen/SPIRV/ tests fail if -DLLVM_EXPERIMENTAL_TARGETS_TO_BUILD contains SPIRV.

% rg -l opaque-pointer llvm/test/CodeGen/SPIRV/
llvm/test/CodeGen/SPIRV/linked-list.ll
llvm/test/CodeGen/SPIRV/image_dim.ll
llvm/test/CodeGen/SPIRV/pstruct.ll
llvm/test/CodeGen/SPIRV/half_no_extension.ll
...

[michalpaszkowski]

@MaskRay @nikic Please see my post on Discourse. The list above is not up to date. Please expect a new patch in the next week, the patch will convert remaining tests to not rely on the flag -opaque-pointers=0 and we will also hopefully remove all remaining API calls to methods related to typed pointers.

Unfortunately, this means that SPIR-V backend will no longer support builtin OpenCL opaque types natively.