Readability check to suggest replacement of conditional statement with std::min/std::max

[EugeneZelenko]

It'll be great to add a readability check to suggest the replacement of conditional statements with std::min/std::max. For example:

if (value1 < value2)
  value1 = value2; // value1 = std::max(value1, value2);
if (value2 < value1)
  value1 = value2; // value1 = std::min(value1, value2);

value2 may be expression, number, etc.

See also PyLint's consider-using-min-builtin and consider-using-max-builtin.

[llvmbot]

@llvm/issue-subscribers-clang-tidy

[PiotrZSL]

From readability point of view your suggestion is correct, from performance point of view it will cause unnecessary assignment that can be cost when called in loop.

[PiotrZSL]

But code like this:

if (value1 < value2)
  value = value2;
else
  value = value1;

could be replaced.... with min/max,
same as:

value = (value1 < value2) ? value1 : value2;

[carlosgalvezp]

Readability checks should not be concerned about performance though.