openmp testing should pass nogpulib

[JonChesterfield]

At present, check-openmp on amdgpu fails with error: cannot find ROCm device library

The test setup is in libomptarget/test/lit.cfg where one can add -nogpulib. That then fails because nogpulib implies no devicertl, which seems dubious to me since openmp definitely cannot ever work without the devicertl. So I'd like to change nogpulib to link in the devicertl anyway.

If we don't want to change that, we can pass lomptarget.devicertl as well as nogpulib to get the right effect.

However I can't see how to do that from lit.cfg. The current commandline flags are prepended before the foo.cpp clause and the explicit library name (either the l form or the archive name) needs to come after it.

Alternatives?

[JonChesterfield]

I wanted to subscribe Joseph but have thus far only found 'assign' in the github UI

[llvmbot]

@llvm/issue-subscribers-openmp

At present, check-openmp on amdgpu fails with `error: cannot find ROCm device library`

The test setup is in libomptarget/test/lit.cfg where one can add -nogpulib. That then fails because nogpulib implies no devicertl, which seems dubious to me since openmp definitely cannot ever work without the devicertl. So I'd like to change nogpulib to link in the devicertl anyway.

If we don't want to change that, we can pass lomptarget.devicertl as well as nogpulib to get the right effect.

However I can't see how to do that from lit.cfg. The current commandline flags are prepended before the foo.cpp clause and the explicit library name (either the l form or the archive name) needs to come after it.

Alternatives?

[JonChesterfield]

Joseph fixed in pull/68225 by passing nogpulib to the tests and also dealing with the devicertl explicitly