Regression tests fail on builds with expensive checks enabled

[kosarev]

$ ninja check-all
...
Failed Tests (13):
  Clang :: Misc/warning-flags-tree.c
  Clang :: Misc/warning-wall.c
  LLVM :: CodeGen/PowerPC/fp-strict.ll
  LLVM :: CodeGen/PowerPC/pr55463.ll
  LLVM :: CodeGen/PowerPC/register-pressure.ll
  LLVM :: CodeGen/PowerPC/spe.ll
  LLVM :: CodeGen/X86/code_placement_ext_tsp.ll  [Fixed]
  LLVM :: CodeGen/X86/code_placement_ext_tsp_large.ll  [Fixed]
  LLVM :: Transforms/Inline/nested-inline.ll  [Fixed]
  LLVM :: Transforms/SampleProfile/csspgo-import-list.ll
  LLVM-Unit :: Transforms/Utils/./UtilsTests/22/37  [Fixed]
  LLVM-Unit :: Transforms/Utils/./UtilsTests/23/37  [Fixed]
  LLVM-Unit :: Transforms/Utils/./UtilsTests/24/37  [Fixed]


Testing Time: 834.97s
  Skipped          :    46
  Unsupported      :   873
  Passed           : 89821
  Expectedly Failed:   195
  Failed           :    13

• https://reviews.llvm.org/D99370#4653452 raises a discussion of the issue for the failure on LLVM :: Transforms/SampleProfile/csspgo-import-list.ll.
• https://reviews.llvm.org/D113424#4653445 is for the LLVM-Unit and CodeGen/X86/* failures. Fixed in [CodeLayout] Fixing initialization of empty ranges #68917.
• https://reviews.llvm.org/D134056#4653598 is for LLVM :: Transforms/Inline/nested-inline.ll. Fixed in [ModuleInliner] Fix the heap maintenance #69251.
• https://reviews.llvm.org/D152437#4653885 is for CodeGen/PowerPC/*.

[llvmbot]

@llvm/issue-subscribers-bug

``` $ ninja check-all ... Failed Tests (13): Clang :: Misc/warning-flags-tree.c Clang :: Misc/warning-wall.c LLVM :: CodeGen/PowerPC/fp-strict.ll LLVM :: CodeGen/PowerPC/pr55463.ll LLVM :: CodeGen/PowerPC/register-pressure.ll LLVM :: CodeGen/PowerPC/spe.ll LLVM :: CodeGen/X86/code_placement_ext_tsp.ll LLVM :: CodeGen/X86/code_placement_ext_tsp_large.ll LLVM :: Transforms/Inline/nested-inline.ll LLVM :: Transforms/SampleProfile/csspgo-import-list.ll LLVM-Unit :: Transforms/Utils/./UtilsTests/22/37 LLVM-Unit :: Transforms/Utils/./UtilsTests/23/37 LLVM-Unit :: Transforms/Utils/./UtilsTests/24/37

Testing Time: 834.97s
Skipped : 46
Unsupported : 873
Passed : 89821
Expectedly Failed: 195
Failed : 13

</details>

[tbaederr]

  Clang :: Misc/warning-flags-tree.c
  Clang :: Misc/warning-wall.c

These two (also) fail for me locally when using -D_GLIBCXX_DEBUG and disabled expensive checks.

[kosarev]

Yes, these only fail on builds using debug versions of libc++, that is, with _GLIBCXX_DEBUG enabled. Our buildbots, such as https://lab.llvm.org/buildbot/#/builders/16 for example, explicitly disable the libc++ consistency checks by undefining this macro.

[DavidSpickett]

See also #73935.

[DavidSpickett]

With my patch for ppc included I'm now down to:

Failed Tests (2):
  LLVM :: ExecutionEngine/JITLink/RISCV/ELF_ehframe.s
  LLVM :: Transforms/SampleProfile/csspgo-import-list.ll