clang-format option AfterPlacementOperator should be a boolean

[owenca]

IMO, we don't need the Leave value for AfterPlacementOperator. @mydeveloperday @HazardyKnusperkeks @rymiel @omarahmed1111 what do you think?

[llvmbot]

@llvm/issue-subscribers-clang-format

Author: Owen Pan (owenca)

IMO, we don't need the `Leave` value for `AfterPlacementOperator`. @mydeveloperday @HazardyKnusperkeks @rymiel @omarahmed1111 what do you think?

[HazardyKnusperkeks]

One does never really need a Leave. But I someone even asked for a leave style to adapt the formatting options one by one. And from that perspective I'm in favor of Leave options, although I'll most likely never use one myself.

[owenca]

A Leave value is needed for some options (e.g. BreakAfterAttributes) but not options like AfterPlacementOperator IMO. Why would we want to support inconsistency in the formatted code irt whether to have a space between the new/delete keyword and the opening parenthesis?

Also, only AfterPlacementOperator is an enum in SpaceBeforeParensOptions. Everything else is a bool. So I think we should change AfterPlacementOperator to a boolean for simplicity and consistency.

[HazardyKnusperkeks]

If you want to convert, that should happen before the LLVM 18 release, after that I'd say we can't remove the Leave option anymore.