[lldb-dap] launchCommands failures always show an error "invalid process"

[ashgti]

When using the lldb-dap, if your debug configuration uses the launchCommands and the command fails instead of reporting an error from the command you will see a dialog saying "invalid process".

The error is coming from https://github.com/llvm/llvm-project/blob/main/lldb/tools/lldb-dap/lldb-dap.cpp#L1790 which is writing over the error reported on line https://github.com/llvm/llvm-project/blob/main/lldb/tools/lldb-dap/lldb-dap.cpp#L1783

[llvmbot]

@llvm/issue-subscribers-lldb

Author: John Harrison (ashgti)

When using the lldb-dap, if your debug configuration uses the `launchCommands` and the command fails instead of reporting an error from the command you will see a dialog saying "invalid process".

The error is coming from https://github.com/llvm/llvm-project/blob/main/lldb/tools/lldb-dap/lldb-dap.cpp#L1790 which is writing over the error reported on line https://github.com/llvm/llvm-project/blob/main/lldb/tools/lldb-dap/lldb-dap.cpp#L1783