[libc][math] some math functions aren't being built in fullbuild mode

[nickdesaulniers]

When doing a fullbuild, I noticed some math functions aren't being built into the resulting libc.a (such as atan2f #86137).

-- Skipping libc entrypoint libc.src.math.acos.
-- Skipping libc entrypoint libc.src.math.acosh.
-- Skipping libc entrypoint libc.src.math.asin.
-- Skipping libc entrypoint libc.src.math.asinh.
-- Skipping libc entrypoint libc.src.math.atan.
-- Skipping libc entrypoint libc.src.math.atan2.
-- Skipping libc entrypoint libc.src.math.atanh.
-- Skipping libc entrypoint libc.src.math.cosh.
-- Skipping libc entrypoint libc.src.math.erf.
-- Skipping libc entrypoint libc.src.math.pow.
-- Skipping libc entrypoint libc.src.math.sincos.
-- Skipping libc entrypoint libc.src.math.sinh.
-- Skipping libc entrypoint libc.src.math.tanh.
-- Skipping libc entrypoint libc.src.math.tgamma.
-- Skipping libc entrypoint libc.src.math.tgammaf.

were listed as being skipped (atan2f wasn't even in that list). I have libmpfr-dev installed (that shouldn't matter either way), but perhaps something else is going wrong with our dependencies, and only in fullbuild mode?

[llvmbot]

@llvm/issue-subscribers-libc

Author: Nick Desaulniers (nickdesaulniers)

When doing a fullbuild, I noticed some math functions aren't being built into the resulting libc.a (such as atan2f #86137).

-- Skipping libc entrypoint libc.src.math.acos.
-- Skipping libc entrypoint libc.src.math.acosh.
-- Skipping libc entrypoint libc.src.math.asin.
-- Skipping libc entrypoint libc.src.math.asinh.
-- Skipping libc entrypoint libc.src.math.atan.
-- Skipping libc entrypoint libc.src.math.atan2.
-- Skipping libc entrypoint libc.src.math.atanh.
-- Skipping libc entrypoint libc.src.math.cosh.
-- Skipping libc entrypoint libc.src.math.erf.
-- Skipping libc entrypoint libc.src.math.pow.
-- Skipping libc entrypoint libc.src.math.sincos.
-- Skipping libc entrypoint libc.src.math.sinh.
-- Skipping libc entrypoint libc.src.math.tanh.
-- Skipping libc entrypoint libc.src.math.tgamma.
-- Skipping libc entrypoint libc.src.math.tgammaf.

were listed as being skipped (atan2f wasn't even in that list). I have libmpfr-dev installed (that shouldn't matter either way), but perhaps something else is going wrong with our dependencies, and only in fullbuild mode?

[nickdesaulniers]

ah, these aren't listed in the entrypoints file!

(once we re-add them, we still have an issue with atan2f though)

[nickdesaulniers]

right, because some of these are currently gpu only.

[nickdesaulniers]

We have libc/src/math/generic/{atan2f|atanf|atanhf}, and yet literally none of those exist for me in projects/libc/lib/libc.a.

$ llvm-nm ./projects/libc/lib/libc.a | grep atan
$

[lntue]

oh, for full build mode, I think we build libc and libm separately.

[nickdesaulniers]

d'oh! That's it!