SymbolFileDWARFDebugMap::FindTypes only finds types defined in the first compile unit

[pabusse]

The early-exit condition inside SymbolFileDWARFDebugMap::FindTypes is inverted:

void SymbolFileDWARFDebugMap::FindTypes(const TypeQuery &query,
                                        TypeResults &results) {
  std::lock_guard<std::recursive_mutex> guard(GetModuleMutex());
  ForEachSymbolFile([&](SymbolFileDWARF *oso_dwarf) -> bool {
    oso_dwarf->FindTypes(query, results);
    return !results.Done(query); // Keep iterating if we aren't done.
  });
}

ForEachSymbolFile stops iterating when the closure returns true. As a result, type queries only consider the first compile unit in a module.

[llvmbot]

@llvm/issue-subscribers-debuginfo

Author: Pablo Busse (pabusse)

The early-exit condition inside `SymbolFileDWARFDebugMap::FindTypes ` is inverted:

void SymbolFileDWARFDebugMap::FindTypes(const TypeQuery &query,
                                        TypeResults &results) {
  std::lock_guard<std::recursive_mutex> guard(GetModuleMutex());
  ForEachSymbolFile([&](SymbolFileDWARF *oso_dwarf) -> bool {
    oso_dwarf->FindTypes(query, results);
    return !results.Done(query); // Keep iterating if we aren't done.
  });
}

ForEachSymbolFile stops iterating when the closure returns true. As a result, type queries only consider the first compile unit in a module.

[llvmbot]

@llvm/issue-subscribers-lldb

Author: Pablo Busse (pabusse)

The early-exit condition inside `SymbolFileDWARFDebugMap::FindTypes ` is inverted:

void SymbolFileDWARFDebugMap::FindTypes(const TypeQuery &query,
                                        TypeResults &results) {
  std::lock_guard<std::recursive_mutex> guard(GetModuleMutex());
  ForEachSymbolFile([&](SymbolFileDWARF *oso_dwarf) -> bool {
    oso_dwarf->FindTypes(query, results);
    return !results.Done(query); // Keep iterating if we aren't done.
  });
}

ForEachSymbolFile stops iterating when the closure returns true. As a result, type queries only consider the first compile unit in a module.