[libc++] _LIBCPP_HAS_NO_UNICODE is missing from __config_site

[BlamKiwi]

_LIBCPP_HAS_NO_UNICODE is not defined in __config_site.in and causes the CMake variable LIBCXX_ENABLE_UNICODE to not be honored.

[ldionne]

Are you sure that's true? We do seem to define it in

llvm-project/libcxx/CMakeLists.txt

Line 778 in 6b21e17

config_define_if_not(LIBCXX_ENABLE_UNICODE _LIBCPP_HAS_NO_UNICODE)

.

Please reopen with a reproducer if you're really seeing this. (I am only closing early to keep issues tidy, don't hesitate to reopen)

[BlamKiwi]

Are you sure that's true? We do seem to define it in

llvm-project/libcxx/CMakeLists.txt

Line 778 in 6b21e17

config_define_if_not(LIBCXX_ENABLE_UNICODE _LIBCPP_HAS_NO_UNICODE)

.

Please reopen with a reproducer if you're really seeing this. (I am only closing early to keep issues tidy, don't hesitate to reopen)

Your CMake defines it, but it's never propagated to the __config_site header because __config_site.in doesn't have #cmakedefine _LIBCPP_HAS_NO_UNICODE

EDIT: https://github.com/llvm/llvm-project/blob/main/libcxx/include/__config_site.in

[ldionne]

You're right, thanks a lot!