clang/lib/Sema/SemaOpenMP.cpp:24774: Pointless test ?

[dcb314]

Static analyser cppcheck says:

clang/lib/Sema/SemaOpenMP.cpp:24774:57: style: Same expression 'DepType!=OMPC_DOACROSS_source' found multiple times in chain of '&&' operators. [duplicateExpression]

Source code is

if (DSAStack->getCurrentDirective() == OMPD_ordered &&
DepType != OMPC_DOACROSS_source && DepType != OMPC_DOACROSS_sink &&
DepType != OMPC_DOACROSS_sink_omp_cur_iteration &&
DepType != OMPC_DOACROSS_source_omp_cur_iteration &&
DepType != OMPC_DOACROSS_source) {

[llvmbot]

@llvm/issue-subscribers-clang-frontend

Author: None (dcb314)

Static analyser cppcheck says:

clang/lib/Sema/SemaOpenMP.cpp:24774:57: style: Same expression 'DepType!=OMPC_DOACROSS_source' found multiple times in chain of '&&' operators. [duplicateExpression]

Source code is

if (DSAStack->getCurrentDirective() == OMPD_ordered &&
DepType != OMPC_DOACROSS_source && DepType != OMPC_DOACROSS_sink &&
DepType != OMPC_DOACROSS_sink_omp_cur_iteration &&
DepType != OMPC_DOACROSS_source_omp_cur_iteration &&
DepType != OMPC_DOACROSS_source) {

[AaronBallman]

#95715 is addressing this issue.