Skip to content

Revert "[libc] New HeaderGen Switch Flip" #100003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Conversation

RoseZhang03
Copy link
Contributor

Reverts #99929

@llvmbot
Copy link
Member

llvmbot commented Jul 22, 2024

@llvm/pr-subscribers-libc

Author: None (RoseZhang03)

Changes

Reverts llvm/llvm-project#99929


Full diff: https://github.com/llvm/llvm-project/pull/100003.diff

1 Files Affected:

  • (modified) libc/CMakeLists.txt (+1-1)
diff --git a/libc/CMakeLists.txt b/libc/CMakeLists.txt
index 45cca17562d26..6e0760724d963 100644
--- a/libc/CMakeLists.txt
+++ b/libc/CMakeLists.txt
@@ -73,7 +73,7 @@ if(LIBC_BUILD_GPU_LOADER OR (LLVM_LIBC_GPU_BUILD AND NOT LLVM_RUNTIMES_BUILD))
   add_subdirectory(utils/gpu)
 endif()
 
-option(LIBC_USE_NEW_HEADER_GEN "Generate header files using new headergen instead of the old one" ON)
+option(LIBC_USE_NEW_HEADER_GEN "Generate header files using new headergen instead of the old one" OFF)
 
 set(NEED_LIBC_HDRGEN FALSE)
 if(NOT LLVM_RUNTIMES_BUILD)

@jhuber6
Copy link
Contributor

jhuber6 commented Jul 22, 2024

Thanks, the minimum Python version accepted by LLVM is 3.8 and the minimum provided by Ubuntu LTS is 3.10, so see if you can get it to work with those.

@jhuber6 jhuber6 merged commit d4da96d into main Jul 22, 2024
14 of 15 checks passed
@jhuber6 jhuber6 deleted the revert-99929-rosezhang17 branch July 22, 2024 23:35
yuxuanchen1997 pushed a commit that referenced this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants