-
Notifications
You must be signed in to change notification settings - Fork 13.6k
[HeaderSearch] Make a test independent of the local environment. #100011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't ask the driver to inspect the local environment but use `cc1` directly.
@llvm/pr-subscribers-clang-modules @llvm/pr-subscribers-clang Author: Volodymyr Sapsai (vsapsai) ChangesDon't ask the driver to inspect the local environment but use Full diff: https://github.com/llvm/llvm-project/pull/100011.diff 1 Files Affected:
diff --git a/clang/test/Modules/subdirectory-module-maps-working-dir.m b/clang/test/Modules/subdirectory-module-maps-working-dir.m
index 4fb19ff05ef38..43488e8d13601 100644
--- a/clang/test/Modules/subdirectory-module-maps-working-dir.m
+++ b/clang/test/Modules/subdirectory-module-maps-working-dir.m
@@ -1,8 +1,8 @@
// RUN: rm -rf %t
-// RUN: %clang -fsyntax-only -fmodules -fmodules-cache-path=%t \
+// RUN: %clang_cc1 -fsyntax-only -fmodules -fimplicit-module-maps -fmodules-cache-path=%t \
// RUN: -working-directory %S/Inputs \
// RUN: -I subdirectory-module-maps-working-dir \
-// RUN: %s -Werror=implicit-function-declaration -Xclang -verify
+// RUN: %s -Werror=implicit-function-declaration -verify
@import ModuleInSubdir;
|
Noticed inconsistencies after #100005 as I have pre-release Xcode locally. |
jansvoboda11
approved these changes
Jul 23, 2024
Failed test is unrelated "Profile-x86_64 :: check-same-common-code.test". |
yuxuanchen1997
pushed a commit
that referenced
this pull request
Jul 25, 2024
…0011) Summary: Don't ask the driver to inspect the local environment but use `cc1` directly. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60250778
cyndyishida
pushed a commit
to cyndyishida/llvm-project
that referenced
this pull request
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
clang:modules
C++20 modules and Clang Header Modules
clang
Clang issues not falling into any other category
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't ask the driver to inspect the local environment but use
cc1
directly.