-
Notifications
You must be signed in to change notification settings - Fork 13.6k
[lldb][test][win][x86_64] XFAIL already failing Shell tests #100476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
# XFAIL: target=x86_64-{{.*}}-windows{{.*}} | ||
# Make sure lldb can handle filenames with single quotes in them. | ||
# RUN: %clang_host %p/Inputs/hello.c -g -o "%t-'pat" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And this looks like you may have a different shell (one that handles quotes differently) from the other windows devs/bots. Maybe we can figure out an invocation that works with both? @DavidSpickett There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm pretty sure we run in cmd.exe. This is how we start the buildbot: https://linaro.atlassian.net/wiki/spaces/TCWGPUB/pages/25310167965/How+to+setup+LLVM+buildbots+for+Windows+on+Arm#Buildbot-startup-script There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The same as for TestConvenienceVariables.test:
|
||
# RUN: %lldb -s %s "%t-'pat" | FileCheck %s | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
# UNSUPPORTED: system-windows | ||
# XFAIL: target=x86_64-{{.*}}-windows{{.*}} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This shouldn't be necessary given the UNSUPPORTED clause above. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. And this test I'm pretty sure is only failing due to cmd line syntax issues, but no confirmation yet. |
||
# | ||
# RUN: %clang_host -g -O0 %S/Inputs/verbose_trap.cpp -o %t.out -DVERBOSE_TRAP_TEST_CATEGORY=\"Foo\" -DVERBOSE_TRAP_TEST_MESSAGE=\"Bar\" | ||
# RUN: %lldb -b -s %s %t.out | FileCheck %s --check-prefixes=CHECK,CHECK-BOTH | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
# XFAIL: target=x86_64-{{.*}}-windows{{.*}} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
# RUN: %lldb -x -b -o 'settings set interpreter.echo-comment-commands true' -s %S/Inputs/EchoCommandsTest.in | FileCheck %S/Inputs/EchoCommandsAll.out | ||
# RUN: %lldb -x -b -o 'settings set interpreter.echo-comment-commands false' -s %S/Inputs/EchoCommandsTest.in | FileCheck %S/Inputs/EchoCommandsNoComments.out | ||
# RUN: %lldb -x -b -o 'settings set interpreter.echo-commands false' -s %S/Inputs/EchoCommandsTest.in | FileCheck %S/Inputs/EchoCommandsNone.out | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
# XFAIL: target=x86_64-{{.*}}-windows{{.*}} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is particularly concerning, given that this test just operates on static binary data (expressed in yaml form). There should be nothing target-specific here. Maybe we could start by looking at what's making this test in particular fail? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We have it green as well
|
||
|
||
# RUN: yaml2obj %s > %t | ||
# RUN: lldb-test symbols %t | FileCheck %s --check-prefix=TEST | ||
# RUN: %lldb %t -o "image dump line-table a.c" -o "image lookup -n _start" -o "image lookup -n f" -o exit | FileCheck %s | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,7 @@ | ||
// clang-format off | ||
|
||
// XFAIL: target=x86_64-{{.*}}-windows{{.*}} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As far as I understand, NativePDB tests only run for Windows host+Windows target, contrary to the tests from the PDB folder which we managed to run on Linux target as part of our effort here https://discourse.llvm.org/t/rfc-lldb-support-remote-run-of-shell-tests/80072/10.
|
||
|
||
// REQUIRES: system-windows | ||
// RUN: %build -o %t.exe -- %s | ||
// RUN: env LLDB_USE_NATIVE_PDB_READER=1 %lldb -f %t.exe -s \ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JDevlieghere please LMK if the target triple can be expressed more clearly as a combination of other filters in
.test
files, here and throughout.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something like
system-windows && target-x86_64
ought to do it. However, like I said in the other review, I think we ought to figure out why are these failing for you.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interestingly, this test is green on our Windows native CI. It uses cmd.exe. Here's the log:
However, I'm unsure if the quotes are printed in log the same way they are passed to cmd.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dzhidzhoev would you be able to share the CMake configuration your Windows native CI is using? I'm having trouble spotting what's wrong with my local build.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference, my current setup steps are the following commands run in a non-admin cmd.exe
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Locally, i've removed CMAKE_CXX_STANDARD=14 above as it is leftover from debugging and not correct or necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For sure! Sorry, I needed some time to sort it out, because I hadn't reproduced it on my local machine before, only had it in CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LLVM_ENABLE_DIA_SDK="OFF"
Seems to have been the culprit for me. After removing this and using the default"ON"
all of the Shell tests I was previously seeing fail are now passing for me. Thanks so much for your help in debugging!