Skip to content

Fix buildbot failure by fixing the base pointer type #100508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 25, 2024
Merged

Fix buildbot failure by fixing the base pointer type #100508

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1be94de
[InstrFDO]Import assume unique local
mingmingl-llvm Jul 23, 2024
d0cc8ba
Merge branch 'main' into vtableref
mingmingl-llvm Jul 23, 2024
78fe701
update test case
mingmingl-llvm Jul 24, 2024
d47ce4e
fix test to make it pass at HEAD
mingmingl-llvm Jul 24, 2024
eff8695
remove debuging logs
mingmingl-llvm Jul 24, 2024
7486f9d
handle indirect callee and indirect ref vtable consistently
mingmingl-llvm Jul 24, 2024
5163477
minor fixes
mingmingl-llvm Jul 24, 2024
c677c57
resolve review feedback
mingmingl-llvm Jul 25, 2024
d6ce694
remove one blank line
mingmingl-llvm Jul 25, 2024
9df09b3
Fix crash PR 100448
mingmingl-llvm Jul 25, 2024
3d30433
run 'git merge main'
mingmingl-llvm Jul 25, 2024
a7f6e49
fix merge conflict
mingmingl-llvm Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions llvm/lib/Transforms/IPO/FunctionImport.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ static std::unique_ptr<Module> loadFile(const std::string &FileName,
return Result;
}

static bool shouldSkipLocalInAnotherModule(const GlobalVarSummary *RefSummary,
static bool shouldSkipLocalInAnotherModule(const GlobalValueSummary *RefSummary,
size_t NumDefs,
StringRef ImporterModule) {
// We can import a local from another module if all inputs are compiled
Expand Down Expand Up @@ -268,8 +268,7 @@ static auto qualifyCalleeCandidates(
// there is only one entry in the list or when all files in the program
// are compiled with full path - in both cases the local function has
// unique PGO name and GUID.
if (shouldSkipLocalInAnotherModule(dyn_cast<GlobalVarSummary>(Summary),
CalleeSummaryList.size(),
if (shouldSkipLocalInAnotherModule(Summary, CalleeSummaryList.size(),
CallerModulePath))
return {
FunctionImporter::ImportFailureReason::LocalLinkageNotInModule,
Expand Down