[WIP][Attributor][AMDGPU] Improve the handling of indirect calls #100954
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
The apparent change here is to simply reverse the effect of #100952 on the lit test. Would be good to have a test which shows what the improvement is. Also, I think #100952 merely enables AAIndirectCallInfo, and feels like an integral part of this change itself. I would lean towards squashing it into this change. |
Yes, this patch is still WIP (draft).
#100953 is based on #100952 because I'd like to demonstrate how the change of function signature will work. |
…imizer pipeline extension point These callbacks can be invoked in multiple places when building an optimization pipeline, both in compile time and link time. However, there is no indicator on what pipeline it is currently building. In this patch, an extra argument is added to indicate its (Thin)LTO stage such that the callback can check it if needed. There is no test expected from this, and the benefit of this change will be demonstrated in #66488.
shiltian
force-pushed
the
users/shiltian/extend-callback-signature
branch
from
9c94910 to
ed46483
Compare
shiltian
force-pushed
the
users/shiltian/improve-indirect-call-handling
branch
from
26e3c81 to
0e498ef
Compare
shiltian
changed the title
shiltian
force-pushed
the
users/shiltian/extend-callback-signature
branch
from
ed46483 to
9980c1f
Compare
|
Moved most of the code to #100952 so this one is no longer needed. Will open a new PR if anything we need to do after the two patches are landed. |
No description provided.