-
Notifications
You must be signed in to change notification settings - Fork 13.6k
[libcxxabi][libunwind] Support for using LLVM libc #101688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
#=============================================================================== | ||
# Define targets for linking against the selected C library | ||
# | ||
# After including this file, the following targets are defined: | ||
# - libcxxabi-libc-headers: An interface target that allows getting access to the | ||
# headers of the selected C library. | ||
# - libcxxabi-libc-shared: A target representing the selected shared C library. | ||
# - libcxxabi-libc-static: A target representing the selected static C library. | ||
#=============================================================================== | ||
|
||
# Link against a system-provided libc | ||
if (LIBCXXABI_LIBC STREQUAL "system") | ||
add_library(libcxxabi-libc-headers INTERFACE) | ||
|
||
add_library(libcxxabi-libc-static INTERFACE) | ||
add_library(libcxxabi-libc-shared INTERFACE) | ||
|
||
# Link against the in-tree LLVM libc | ||
elseif (LIBCXXABI_LIBC STREQUAL "llvm-libc") | ||
add_library(libcxxabi-libc-headers INTERFACE) | ||
target_link_libraries(libcxxabi-libc-headers INTERFACE libc-headers) | ||
if(CXX_SUPPORTS_NOSTDLIBINC_FLAG) | ||
target_compile_options(libcxxabi-libc-headers INTERFACE "-nostdlibinc") | ||
endif() | ||
|
||
add_library(libcxxabi-libc-static INTERFACE) | ||
if (TARGET libc) | ||
target_link_libraries(libcxxabi-libc-static INTERFACE libc) | ||
endif() | ||
if (TARGET libm) | ||
target_link_libraries(libcxxabi-libc-static INTERFACE libm) | ||
endif() | ||
if (CXX_SUPPORTS_NOLIBC_FLAG) | ||
target_link_options(libcxxabi-libc-static INTERFACE "-nolibc") | ||
endif() | ||
|
||
# TODO: There's no support for building LLVM libc as a shared library yet. | ||
add_library(libcxxabi-libc-shared INTERFACE) | ||
endif() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
#=============================================================================== | ||
# Define targets for linking against the selected C library | ||
# | ||
# After including this file, the following targets are defined: | ||
# - libunwind-libc-headers: An interface target that allows getting access to the | ||
# headers of the selected C library. | ||
# - libunwind-libc-shared: A target representing the selected shared C library. | ||
# - libunwind-libc-static: A target representing the selected static C library. | ||
#=============================================================================== | ||
|
||
# Link against a system-provided libc | ||
if (LIBUNWIND_LIBC STREQUAL "system") | ||
add_library(libunwind-libc-headers INTERFACE) | ||
|
||
add_library(libunwind-libc-static INTERFACE) | ||
add_library(libunwind-libc-shared INTERFACE) | ||
|
||
# Link against the in-tree LLVM libc | ||
elseif (LIBUNWIND_LIBC STREQUAL "llvm-libc") | ||
add_library(libunwind-libc-headers INTERFACE) | ||
target_link_libraries(libunwind-libc-headers INTERFACE libc-headers) | ||
if(CXX_SUPPORTS_NOSTDLIBINC_FLAG) | ||
target_compile_options(libunwind-libc-headers INTERFACE "-nostdlibinc") | ||
endif() | ||
|
||
add_library(libunwind-libc-static INTERFACE) | ||
if (TARGET libc) | ||
target_link_libraries(libunwind-libc-static INTERFACE libc) | ||
endif() | ||
if (TARGET libm) | ||
target_link_libraries(libunwind-libc-static INTERFACE libm) | ||
endif() | ||
if (CXX_SUPPORTS_NOLIBC_FLAG) | ||
target_link_options(libunwind-libc-static INTERFACE "-nolibc") | ||
endif() | ||
|
||
# TODO: There's no support for building LLVM libc as a shared library yet. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was about to mention that but then I saw this comment. |
||
add_library(libunwind-libc-shared INTERFACE) | ||
endif() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, can't you include
libcxx/cmake/Modules/HandleLibC.cmake
instead?