[libc++] The rest of P2278R4 (cdata, as_const_view, span changes) #102301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
frederick-vs-ja
requested changes
Aug 7, 2024
Papers: [P2278R4][], [P2836R1][]
PR: [LLVM-PR-99915][]
Implements:
- `basic_const_iterator`, `const_iterator`, and `const_sentinel`
- The const accessors - `ranges::{cbegin,cend,crbegin,crend}`
- Add `cbegin` and `cend` member functions to `view_interface`
- The changes from [P2836R1][].
Still to be done:
- `ranges::as_const_view`, `ranges::views::as_const`
- `cdata`
- The changes to `span`
Drive-by:
- Fix some includes that would have been circular.
[P2278R4]: https://wg21.link/p2278r4
[P2836R1]: https://wg21.link/p2836r1
[LLVM-PR-99915]: llvm#99915
drive-by: remove the `__ranges/data.h` header and merge it with `__ranges/access.h` (for `ranges::data`), or `__ranges/const_access.h` (for `ranges::cdata`). I felt comfortable doing this as every use of `__ranges/access.h` included either `__ranges/data.h` itself, or `__ranges/concepts.h` which itself included `__ranges/data.h`.
Note that we have an interesting extension in `span` to support volatile types - this breaks `std::const_iterator`. I've made the choice to, when `span`'s element type is `volatile`, set `const_iterator` and `const_reverse_iterator` to `void`, and disable `cbegin` and friends.
includes testing
I wonder if it would be a good idea to do something more similar to what MSVC does here, with `_Choice` stuff.
strega-nil
force-pushed
the
p2278r4_cdata_span
branch
from
3ee5363 to
659a4fb
Compare
|
Closing as this will be merged into the original PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on, and is committed on top of, LLVM-PR-99915.
This PR completes the rest of P2278R4 that was not done in the original PR:
Actual changes (excluding those from LLVM-PR-99915): diff 99915.
cdataspan(includes some interesting choices sinceconst_iteratorcannot supportvolatileelement types)as_const_viewandviews::as_const__cpp_lib_ranges_as_constfeature macro