Skip to content

[libcxx] [test] Mark gdb_pretty_printer_test.sh.cpp as unsupported on Windows #102891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

mstorsjo
Copy link
Member

In practice, this test hasn't been run by any of the Windows configurations so far, because it has been excluded by the "UNSUPPORTED: clang-18, clang-19" line - but it does end up failing if running with e.g. clang-20 on Windows.

As the test fails on more fundamental issues on Windows, mark it outright unsupported on this platform; this fixes testing libcxx with a recent nightly version of Clang from git main.

… Windows

In practice, this test hasn't been run by any of the Windows
configurations so far, because it has been excluded by the
"UNSUPPORTED: clang-18, clang-19" line - but it does end up
failing if running with e.g. clang-20 on Windows.

As the test fails on more fundamental issues on Windows, mark
it outright unsupported on this platform; this fixes testing
libcxx with a recent nightly version of Clang from git main.
@mstorsjo mstorsjo requested a review from a team as a code owner August 12, 2024 12:36
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Aug 12, 2024
@llvmbot
Copy link
Member

llvmbot commented Aug 12, 2024

@llvm/pr-subscribers-libcxx

Author: Martin Storsjö (mstorsjo)

Changes

In practice, this test hasn't been run by any of the Windows configurations so far, because it has been excluded by the "UNSUPPORTED: clang-18, clang-19" line - but it does end up failing if running with e.g. clang-20 on Windows.

As the test fails on more fundamental issues on Windows, mark it outright unsupported on this platform; this fixes testing libcxx with a recent nightly version of Clang from git main.


Full diff: https://github.com/llvm/llvm-project/pull/102891.diff

1 Files Affected:

  • (modified) libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp (+3)
diff --git a/libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp b/libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp
index 4c2b483914f47e..2c8534977febc7 100644
--- a/libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp
+++ b/libcxx/test/libcxx/gdb/gdb_pretty_printer_test.sh.cpp
@@ -20,6 +20,9 @@
 // support gdb anymore, favoring lldb instead.
 // UNSUPPORTED: android
 
+// This test doesn't work as such on Windows.
+// UNSUPPORTED: windows
+
 // RUN: %{cxx} %{flags} %s -o %t.exe %{compile_flags} -g %{link_flags}
 // Ensure locale-independence for unicode tests.
 // RUN: env LANG=en_US.UTF-8 %{gdb} -nx -batch -iex "set autoload off" -ex "source %S/../../../utils/gdb/libcxx/printers.py" -ex "python register_libcxx_printer_loader()" -ex "source %S/gdb_pretty_printer_test.py" %t.exe

@mstorsjo mstorsjo merged commit a2acea5 into llvm:main Aug 12, 2024
55 of 57 checks passed
@mstorsjo mstorsjo deleted the libcxx-test-gdb-windows branch August 12, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants