Skip to content

scan-build-py: respect LLVM_LIBDIR_SUFFIX like other tools do #108549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shr-project
Copy link

  • other libraries are installed in 'lib64' or 'lib32' based on LLVM_LIBDIR_SUFFIX value, but libscanbuild files were always installed in 'lib'

* other libraries are installed in 'lib64' or 'lib32' based on
  LLVM_LIBDIR_SUFFIX value, but libscanbuild files were always
  installed in 'lib'

Signed-off-by: Martin Jansa <[email protected]>
Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@nikic
Copy link
Contributor

nikic commented Sep 14, 2024

It looks like you're trying to undo #106612? cc @mgorny

@shr-project
Copy link
Author

shr-project commented Sep 14, 2024

It looks like you're trying to undo #106612? cc @mgorny

Ah, not intentionally, I should have checked the git history more carefully before creating this PR (which is still only a draft). I don't use libscanbuild at all, but in OpenEmbedded builds the python modules are installed in the configured libdir which could be /usr/lib, /usr/lib32, /usr/lib64 and then they are packaged correctly, while libscanbuild didn't follow this and caused installed-vs-shipped QA issue (which basically means that something was installed in locations which aren't packaged by configured rules).

I believe the python code (d9cf829) should be fixed to look in the right install locations, but I'll leave that to someone actually using libscanbuild.

@mgorny
Copy link
Member

mgorny commented Sep 14, 2024

Sounds like a bug in OpenEmbedded then. CPython installs Python modules in /usr/lib, unconditionally.

kraj pushed a commit to kraj/llvm-project that referenced this pull request Apr 25, 2025
* other libraries are installed in 'lib64' or 'lib32' based on
  LLVM_LIBDIR_SUFFIX value, but libscanbuild files were always
  installed in 'lib'

Upstream-Status: Submitted [llvm#108549]

Signed-off-by: Martin Jansa <[email protected]>
kraj pushed a commit to kraj/llvm-project that referenced this pull request Apr 25, 2025
* other libraries are installed in 'lib64' or 'lib32' based on
  LLVM_LIBDIR_SUFFIX value, but libscanbuild files were always
  installed in 'lib'

Upstream-Status: Submitted [llvm#108549]

Signed-off-by: Martin Jansa <[email protected]>
kraj pushed a commit to kraj/llvm-project that referenced this pull request Apr 25, 2025
* other libraries are installed in 'lib64' or 'lib32' based on
  LLVM_LIBDIR_SUFFIX value, but libscanbuild files were always
  installed in 'lib'

Upstream-Status: Submitted [llvm#108549]

Signed-off-by: Martin Jansa <[email protected]>
kraj pushed a commit to kraj/llvm-project that referenced this pull request Apr 25, 2025
* other libraries are installed in 'lib64' or 'lib32' based on
  LLVM_LIBDIR_SUFFIX value, but libscanbuild files were always
  installed in 'lib'

Upstream-Status: Submitted [llvm#108549]

Signed-off-by: Martin Jansa <[email protected]>
kraj pushed a commit to kraj/llvm-project that referenced this pull request Apr 25, 2025
* other libraries are installed in 'lib64' or 'lib32' based on
  LLVM_LIBDIR_SUFFIX value, but libscanbuild files were always
  installed in 'lib'

Upstream-Status: Submitted [llvm#108549]

Signed-off-by: Martin Jansa <[email protected]>
kraj pushed a commit to kraj/llvm-project that referenced this pull request Apr 28, 2025
* other libraries are installed in 'lib64' or 'lib32' based on
  LLVM_LIBDIR_SUFFIX value, but libscanbuild files were always
  installed in 'lib'

Upstream-Status: Submitted [llvm#108549]

Signed-off-by: Martin Jansa <[email protected]>
kraj pushed a commit to kraj/llvm-project that referenced this pull request Apr 28, 2025
* other libraries are installed in 'lib64' or 'lib32' based on
  LLVM_LIBDIR_SUFFIX value, but libscanbuild files were always
  installed in 'lib'

Upstream-Status: Submitted [llvm#108549]

Signed-off-by: Martin Jansa <[email protected]>
kraj pushed a commit to kraj/llvm-project that referenced this pull request May 1, 2025
* other libraries are installed in 'lib64' or 'lib32' based on
  LLVM_LIBDIR_SUFFIX value, but libscanbuild files were always
  installed in 'lib'

Upstream-Status: Submitted [llvm#108549]

Signed-off-by: Martin Jansa <[email protected]>
kraj pushed a commit to kraj/llvm-project that referenced this pull request May 1, 2025
* other libraries are installed in 'lib64' or 'lib32' based on
  LLVM_LIBDIR_SUFFIX value, but libscanbuild files were always
  installed in 'lib'

Upstream-Status: Submitted [llvm#108549]

Signed-off-by: Martin Jansa <[email protected]>
kraj pushed a commit to kraj/llvm-project that referenced this pull request May 1, 2025
* other libraries are installed in 'lib64' or 'lib32' based on
  LLVM_LIBDIR_SUFFIX value, but libscanbuild files were always
  installed in 'lib'

Upstream-Status: Submitted [llvm#108549]

Signed-off-by: Martin Jansa <[email protected]>
kraj pushed a commit to kraj/llvm-project that referenced this pull request May 6, 2025
* other libraries are installed in 'lib64' or 'lib32' based on
  LLVM_LIBDIR_SUFFIX value, but libscanbuild files were always
  installed in 'lib'

Upstream-Status: Submitted [llvm#108549]

Signed-off-by: Martin Jansa <[email protected]>
kraj pushed a commit to kraj/llvm-project that referenced this pull request May 6, 2025
* other libraries are installed in 'lib64' or 'lib32' based on
  LLVM_LIBDIR_SUFFIX value, but libscanbuild files were always
  installed in 'lib'

Upstream-Status: Submitted [llvm#108549]

Signed-off-by: Martin Jansa <[email protected]>
kraj pushed a commit to kraj/llvm-project that referenced this pull request May 8, 2025
* other libraries are installed in 'lib64' or 'lib32' based on
  LLVM_LIBDIR_SUFFIX value, but libscanbuild files were always
  installed in 'lib'

Upstream-Status: Submitted [llvm#108549]

Signed-off-by: Martin Jansa <[email protected]>
kraj pushed a commit to kraj/llvm-project that referenced this pull request May 9, 2025
* other libraries are installed in 'lib64' or 'lib32' based on
  LLVM_LIBDIR_SUFFIX value, but libscanbuild files were always
  installed in 'lib'

Upstream-Status: Submitted [llvm#108549]

Signed-off-by: Martin Jansa <[email protected]>
kraj pushed a commit to kraj/llvm-project that referenced this pull request May 10, 2025
* other libraries are installed in 'lib64' or 'lib32' based on
  LLVM_LIBDIR_SUFFIX value, but libscanbuild files were always
  installed in 'lib'

Upstream-Status: Submitted [llvm#108549]

Signed-off-by: Martin Jansa <[email protected]>
kraj pushed a commit to kraj/llvm-project that referenced this pull request May 10, 2025
* other libraries are installed in 'lib64' or 'lib32' based on
  LLVM_LIBDIR_SUFFIX value, but libscanbuild files were always
  installed in 'lib'

Upstream-Status: Submitted [llvm#108549]

Signed-off-by: Martin Jansa <[email protected]>
kraj pushed a commit to kraj/llvm-project that referenced this pull request May 10, 2025
* other libraries are installed in 'lib64' or 'lib32' based on
  LLVM_LIBDIR_SUFFIX value, but libscanbuild files were always
  installed in 'lib'

Upstream-Status: Submitted [llvm#108549]

Signed-off-by: Martin Jansa <[email protected]>
kraj pushed a commit to kraj/llvm-project that referenced this pull request May 15, 2025
* other libraries are installed in 'lib64' or 'lib32' based on
  LLVM_LIBDIR_SUFFIX value, but libscanbuild files were always
  installed in 'lib'

Upstream-Status: Submitted [llvm#108549]

Signed-off-by: Martin Jansa <[email protected]>
kraj pushed a commit to kraj/llvm-project that referenced this pull request May 15, 2025
* other libraries are installed in 'lib64' or 'lib32' based on
  LLVM_LIBDIR_SUFFIX value, but libscanbuild files were always
  installed in 'lib'

Upstream-Status: Submitted [llvm#108549]

Signed-off-by: Martin Jansa <[email protected]>
kraj pushed a commit to kraj/llvm-project that referenced this pull request May 18, 2025
* other libraries are installed in 'lib64' or 'lib32' based on
  LLVM_LIBDIR_SUFFIX value, but libscanbuild files were always
  installed in 'lib'

Upstream-Status: Submitted [llvm#108549]

Signed-off-by: Martin Jansa <[email protected]>
kraj pushed a commit to kraj/llvm-project that referenced this pull request May 18, 2025
* other libraries are installed in 'lib64' or 'lib32' based on
  LLVM_LIBDIR_SUFFIX value, but libscanbuild files were always
  installed in 'lib'

Upstream-Status: Submitted [llvm#108549]

Signed-off-by: Martin Jansa <[email protected]>
kraj pushed a commit to kraj/llvm-project that referenced this pull request May 19, 2025
* other libraries are installed in 'lib64' or 'lib32' based on
  LLVM_LIBDIR_SUFFIX value, but libscanbuild files were always
  installed in 'lib'

Upstream-Status: Submitted [llvm#108549]

Signed-off-by: Martin Jansa <[email protected]>
kraj pushed a commit to kraj/llvm-project that referenced this pull request May 19, 2025
* other libraries are installed in 'lib64' or 'lib32' based on
  LLVM_LIBDIR_SUFFIX value, but libscanbuild files were always
  installed in 'lib'

Upstream-Status: Submitted [llvm#108549]

Signed-off-by: Martin Jansa <[email protected]>
kraj pushed a commit to kraj/llvm-project that referenced this pull request May 21, 2025
* other libraries are installed in 'lib64' or 'lib32' based on
  LLVM_LIBDIR_SUFFIX value, but libscanbuild files were always
  installed in 'lib'

Upstream-Status: Submitted [llvm#108549]

Signed-off-by: Martin Jansa <[email protected]>
kraj pushed a commit to kraj/llvm-project that referenced this pull request May 21, 2025
* other libraries are installed in 'lib64' or 'lib32' based on
  LLVM_LIBDIR_SUFFIX value, but libscanbuild files were always
  installed in 'lib'

Upstream-Status: Submitted [llvm#108549]

Signed-off-by: Martin Jansa <[email protected]>
kraj pushed a commit to kraj/llvm-project that referenced this pull request May 22, 2025
* other libraries are installed in 'lib64' or 'lib32' based on
  LLVM_LIBDIR_SUFFIX value, but libscanbuild files were always
  installed in 'lib'

Upstream-Status: Submitted [llvm#108549]

Signed-off-by: Martin Jansa <[email protected]>
kraj pushed a commit to kraj/llvm-project that referenced this pull request May 22, 2025
* other libraries are installed in 'lib64' or 'lib32' based on
  LLVM_LIBDIR_SUFFIX value, but libscanbuild files were always
  installed in 'lib'

Upstream-Status: Submitted [llvm#108549]

Signed-off-by: Martin Jansa <[email protected]>
kraj pushed a commit to kraj/llvm-project that referenced this pull request May 23, 2025
* other libraries are installed in 'lib64' or 'lib32' based on
  LLVM_LIBDIR_SUFFIX value, but libscanbuild files were always
  installed in 'lib'

Upstream-Status: Submitted [llvm#108549]

Signed-off-by: Martin Jansa <[email protected]>
kraj pushed a commit to kraj/llvm-project that referenced this pull request May 23, 2025
* other libraries are installed in 'lib64' or 'lib32' based on
  LLVM_LIBDIR_SUFFIX value, but libscanbuild files were always
  installed in 'lib'

Upstream-Status: Submitted [llvm#108549]

Signed-off-by: Martin Jansa <[email protected]>
kraj pushed a commit to kraj/llvm-project that referenced this pull request May 23, 2025
* other libraries are installed in 'lib64' or 'lib32' based on
  LLVM_LIBDIR_SUFFIX value, but libscanbuild files were always
  installed in 'lib'

Upstream-Status: Submitted [llvm#108549]

Signed-off-by: Martin Jansa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants