[lldb][intel-pt] Fix build error on conversion from llvm::Error to Status::FromError

[kusmour]

Summary: This introduced from upstream #107163

Test Plan: I can build

Closes: #107580

[llvmbot]

@llvm/pr-subscribers-lldb

Author: Wanyi (kusmour)

Changes

Summary: This introduced from upstream #107163

Test Plan: I can build

---

Full diff: https://github.com/llvm/llvm-project/pull/108719.diff

1 Files Affected:

• (modified) lldb/source/Plugins/Trace/intel-pt/CommandObjectTraceStartIntelPT.cpp (+2-2)

diff --git a/lldb/source/Plugins/Trace/intel-pt/CommandObjectTraceStartIntelPT.cpp b/lldb/source/Plugins/Trace/intel-pt/CommandObjectTraceStartIntelPT.cpp
index 81f7c228561a6d..40035e4480495f 100644
--- a/lldb/source/Plugins/Trace/intel-pt/CommandObjectTraceStartIntelPT.cpp
+++ b/lldb/source/Plugins/Trace/intel-pt/CommandObjectTraceStartIntelPT.cpp
@@ -78,7 +78,7 @@ bool CommandObjectThreadTraceStartIntelPT::DoExecuteOnThreads(
     llvm::ArrayRef<lldb::tid_t> tids) {
   if (Error err = m_trace.Start(tids, m_options.m_ipt_trace_size,
                                 m_options.m_enable_tsc, m_options.m_psb_period))
-    result.SetError(Status(std::move(err)));
+    result.SetError(Status::FromError(std::move(err)));
   else
     result.SetStatus(eReturnStatusSuccessFinishResult);
 
@@ -164,7 +164,7 @@ void CommandObjectProcessTraceStartIntelPT::DoExecute(
           m_options.m_ipt_trace_size, m_options.m_process_buffer_size_limit,
           m_options.m_enable_tsc, m_options.m_psb_period,
           m_options.m_per_cpu_tracing, m_options.m_disable_cgroup_filtering))
-    result.SetError(Status(std::move(err)));
+    result.SetError(Status::FromError(std::move(err)));
   else
     result.SetStatus(eReturnStatusSuccessFinishResult);
 }

[Jlalond]

Hey @kusmour. I actually looked into this on Thursday, see #108248. If we are going to merge this I think we should just call std::move and not Status::FromError(std::move(err)) as the API takes an err r-value.

[walter-erquinigo]

just make sure that you really need to invoke std::move. It's possible that the compiler can do that on its own and that you don't need the explicit std::move