Skip to content

Add missing extendhfxf2 in compiler rt #109090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions compiler-rt/lib/builtins/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ set(GENERIC_SOURCES
divti3.c
extendsfdf2.c
extendhfsf2.c
extendhfxf2.c
ffsdi2.c
ffssi2.c
ffsti2.c
Expand Down
18 changes: 18 additions & 0 deletions compiler-rt/lib/builtins/extendhfxf2.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
//===-- lib/extendhfxf2.c - half -> long double conversion --------*- C -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//

#define SRC_HALF
#define DST_DOUBLE
#include "fp_extend_impl.inc"

// Use a forwarding definition and noinline to implement a poor man's alias,
// as there isn't a good cross-platform way of defining one.
// Long double are expected to be as precise as double.
COMPILER_RT_ABI NOINLINE long double __extendhfxf2(src_t a) {
return (long double)__extendXfYf2__(a);
}
1 change: 1 addition & 0 deletions compiler-rt/lib/builtins/macho_embedded/common.txt
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ divsf3
divsi3
extendsfdf2
extendhfsf2
extendhfxf2
ffssi2
fixdfsi
fixsfsi
Expand Down
61 changes: 61 additions & 0 deletions compiler-rt/test/builtins/Unit/extendhfxf2_test.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
// RUN: %clang_builtins %s %librt -o %t && %run %t
// REQUIRES: librt_has_extendhfxf2

#include <limits.h>
#include <math.h> // for isnan, isinf
#include <stdio.h>

long double __extendhfxf2(_Float16 f);

int test_extendhfxf2(_Float16 a, long double expected) {
long double x = __extendhfxf2(a);
__uint16_t *b = (void *)&a;
int ret = !(x == expected || (isnan(x) && isnan(expected)) ||
(isinf(x) && isinf(expected) && x == expected));
if (ret) {
printf("error in test__extendhfsf2(%#.4x) = %.20Lf, "
"expected %.20Lf\n",
*b, x, expected);
}
return ret;
}

char assumption_1[sizeof(_Float16) * CHAR_BIT == 16] = {0};

int main() {
// Small positive value
if (test_extendhfxf2(0.09997558593750000000f, 0.09997558593750000000L))
return 1;

// Small negative value
if (test_extendhfxf2(-0.09997558593750000000f, -0.09997558593750000000L))
return 1;

// Zero
if (test_extendhfxf2(0.0f, 0.0L))
return 1;

// Smallest positive non-zero value
if (test_extendhfxf2(0x1p-16f, 0x1p-16L))
return 1;

// Smallest negative non-zero value
if (test_extendhfxf2(-0x1p-16f, -0x1p-16L))
return 1;

// Positive infinity
if (test_extendhfxf2(__builtin_huge_valf16(), __builtin_huge_valf64x()))
return 1;

// Negative infinity
if (test_extendhfxf2(-__builtin_huge_valf16(),
(long double)-__builtin_huge_valf64x()))
return 1;

// NaN
if (test_extendhfxf2(__builtin_nanf16(""),
(long double)__builtin_nanf64x("")))
return 1;

return 0;
}
1 change: 1 addition & 0 deletions llvm/utils/gn/secondary/compiler-rt/lib/builtins/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ static_library("builtins") {
"divsi3.c",
"divti3.c",
"extendhfsf2.c",
"extendhfxf2.c"
"extendsfdf2.c",
"ffsdi2.c",
"ffssi2.c",
Expand Down
Loading