[LLDB][ProcessELFCore] Add Description to ProcessELFCore/ELFThread stop reasons #110065

Jlalond · 2024-09-26T00:46:31Z

This fixes a functionality gap with GDB, where GDB will properly decode the stop reason and give the address for SIGSEGV. I also added descriptions to all stop reasons, following the same code path that the Native Linux Thread uses.

llvmbot · 2024-09-26T00:47:12Z

@llvm/pr-subscribers-lldb

Author: Jacob Lalonde (Jlalond)

Changes

This fixes a functionality gap with GDB, where GDB will properly decode the stop reason and give the address for SIGSEGV. I also added descriptions to all stop reasons, following the same code path that the Native Linux Thread uses.

Full diff: https://github.com/llvm/llvm-project/pull/110065.diff

3 Files Affected:

(modified) lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp (+1)
(modified) lldb/source/Plugins/Process/elf-core/ThreadElfCore.cpp (+35-5)
(modified) lldb/source/Plugins/Process/elf-core/ThreadElfCore.h (+15-3)

diff --git a/lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp b/lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp
index 7955594bf5d94c..468a3b8934e741 100644
--- a/lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp
+++ b/lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp
@@ -931,6 +931,7 @@ llvm::Error ProcessElfCore::parseLinuxNotes(llvm::ArrayRef<CoreNote> notes) {
         return status.ToError();
       thread_data.signo = siginfo.si_signo;
       thread_data.code = siginfo.si_code;
+      thread_data.description = siginfo.GetDescription();
       break;
     }
     case ELF::NT_FILE: {
diff --git a/lldb/source/Plugins/Process/elf-core/ThreadElfCore.cpp b/lldb/source/Plugins/Process/elf-core/ThreadElfCore.cpp
index 52b96052bdbeca..e9ae5211c28a53 100644
--- a/lldb/source/Plugins/Process/elf-core/ThreadElfCore.cpp
+++ b/lldb/source/Plugins/Process/elf-core/ThreadElfCore.cpp
@@ -9,6 +9,7 @@
 #include "lldb/Target/RegisterContext.h"
 #include "lldb/Target/StopInfo.h"
 #include "lldb/Target/Target.h"
+#include "lldb/Target/UnixSignals.h"
 #include "lldb/Target/Unwind.h"
 #include "lldb/Utility/DataExtractor.h"
 #include "lldb/Utility/LLDBLog.h"
@@ -49,8 +50,8 @@ using namespace lldb_private;
 // Construct a Thread object with given data
 ThreadElfCore::ThreadElfCore(Process &process, const ThreadData &td)
     : Thread(process, td.tid), m_thread_name(td.name), m_thread_reg_ctx_sp(),
-      m_signo(td.signo), m_code(td.code), m_gpregset_data(td.gpregset),
-      m_notes(td.notes) {}
+      m_signo(td.signo), m_code(td.code), m_sig_description(td.description),
+      m_gpregset_data(td.gpregset), m_notes(td.notes) {}
 
 ThreadElfCore::~ThreadElfCore() { DestroyThread(); }
 
@@ -241,7 +242,7 @@ bool ThreadElfCore::CalculateStopInfo() {
     return false;
 
   SetStopInfo(StopInfo::CreateStopReasonWithSignal(
-      *this, m_signo, /*description=*/nullptr, m_code));
+      *this, m_signo, m_sig_description.c_str(), m_code));
   return true;
 }
 
@@ -543,7 +544,8 @@ size_t ELFLinuxSigInfo::GetSize(const lldb_private::ArchSpec &arch) {
 
 Status ELFLinuxSigInfo::Parse(const DataExtractor &data, const ArchSpec &arch) {
   Status error;
-  if (GetSize(arch) > data.GetByteSize()) {
+  uint64_t size = GetSize(arch);
+  if (size > data.GetByteSize()) {
     error = Status::FromErrorStringWithFormat(
         "NT_SIGINFO size should be %zu, but the remaining bytes are: %" PRIu64,
         GetSize(arch), data.GetByteSize());
@@ -556,6 +558,34 @@ Status ELFLinuxSigInfo::Parse(const DataExtractor &data, const ArchSpec &arch) {
   si_signo = data.GetU32(&offset);
   si_errno = data.GetU32(&offset);
   si_code = data.GetU32(&offset);
+  // 64b ELF have a 4 byte pad.
+  if (data.GetAddressByteSize() == 8)
+    offset += 4;
+  switch (si_signo) {
+  case SIGFPE:
+  case SIGILL:
+  case SIGSEGV:
+  case SIGBUS:
+  case SIGTRAP:
+    addr = (void *)data.GetAddress(&offset);
+    addr_lsb = data.GetU16(&offset);
+    return error;
+  default:
+    return error;
+  }
+}
 
-  return error;
+std::string ELFLinuxSigInfo::GetDescription() {
+  switch (si_signo) {
+  case SIGFPE:
+  case SIGILL:
+  case SIGSEGV:
+  case SIGBUS:
+  case SIGTRAP:
+    return lldb_private::UnixSignals::CreateForHost()->GetSignalDescription(
+        si_signo, si_code, reinterpret_cast<uintptr_t>(addr));
+  default:
+    return lldb_private::UnixSignals::CreateForHost()->GetSignalDescription(
+        si_signo, si_code);
+  }
 }
diff --git a/lldb/source/Plugins/Process/elf-core/ThreadElfCore.h b/lldb/source/Plugins/Process/elf-core/ThreadElfCore.h
index 3fa0b8b0eedb0b..3c6c02f73efae8 100644
--- a/lldb/source/Plugins/Process/elf-core/ThreadElfCore.h
+++ b/lldb/source/Plugins/Process/elf-core/ThreadElfCore.h
@@ -75,16 +75,25 @@ struct ELFLinuxPrStatus {
 static_assert(sizeof(ELFLinuxPrStatus) == 112,
               "sizeof ELFLinuxPrStatus is not correct!");
 
+union ELFSigval {
+  int sival_int;
+  void *sival_ptr;
+};
+
 struct ELFLinuxSigInfo {
-  int32_t si_signo;
-  int32_t si_code;
+  int32_t si_signo; // Order matters for the first 3.
   int32_t si_errno;
+  int32_t si_code;
+  void *addr;       /* faulting insn/memory ref. */
+  int32_t addr_lsb; /* Valid LSB of the reported address.  */
 
   ELFLinuxSigInfo();
 
   lldb_private::Status Parse(const lldb_private::DataExtractor &data,
                              const lldb_private::ArchSpec &arch);
 
+  std::string GetDescription();
+
   // Return the bytesize of the structure
   // 64 bit - just sizeof
   // 32 bit - hardcoded because we are reusing the struct, but some of the
@@ -93,7 +102,7 @@ struct ELFLinuxSigInfo {
   static size_t GetSize(const lldb_private::ArchSpec &arch);
 };
 
-static_assert(sizeof(ELFLinuxSigInfo) == 12,
+static_assert(sizeof(ELFLinuxSigInfo) == 32,
               "sizeof ELFLinuxSigInfo is not correct!");
 
 // PRPSINFO structure's size differs based on architecture.
@@ -144,7 +153,9 @@ struct ThreadData {
   lldb::tid_t tid;
   int signo = 0;
   int code = 0;
+  void *sigaddr = nullptr;
   int prstatus_sig = 0;
+  std::string description;
   std::string name;
 };
 
@@ -183,6 +194,7 @@ class ThreadElfCore : public lldb_private::Thread {
 
   int m_signo;
   int m_code;
+  std::string m_sig_description;
 
   lldb_private::DataExtractor m_gpregset_data;
   std::vector<lldb_private::CoreNote> m_notes;

Jlalond · 2024-09-26T21:10:51Z

Looks like I got some failures due to the tests expecting an exact string match. Will fix

DavidSpickett · 2024-09-27T09:06:30Z

So does this not need new testing or did you not add that yet?

I'm not clear on what fully decode means because at least for certain signals like a tag check fault we do have a description for live processes and core files. Perhaps that's because I added those as special cases I don't remember the specifics.

labath · 2024-09-27T09:07:46Z

Seems reasonable, but you'll need to use the signal constants from UnixSignals (looked up by string), as macros like SIGBUS might not exist (windows) or might not have the right value (macos). (NativeThreadLinux can get away with using them as it always runs on the host.)

DavidSpickett · 2024-09-27T09:17:44Z

Perhaps that's because I added those as special cases I don't remember the specifics.

I only added part of the description - 85bc498. Didn't add the fault address.

Happy to see improvements here!

Jlalond · 2024-09-27T16:28:27Z

So does this not need new testing or did you not add that yet?

I'm not clear on what fully decode means because at least for certain signals like a tag check fault we do have a description for live processes and core files. Perhaps that's because I added those as special cases I don't remember the specifics.

I actually tried to yamlize one of my test crash dumps. The issue I encountered was the PT_NOTE sections wasn't being generated with content. Is there a way with obj2yaml to generate PT_NOTES with content?

Jlalond · 2024-09-27T16:28:53Z

Seems reasonable, but you'll need to use the signal constants from UnixSignals (looked up by string), as macros like SIGBUS might not exist (windows) or might not have the right value (macos). (NativeThreadLinux can get away with using them as it always runs on the host.)

You're referring to the properties in the ELFSignal object?

lldb/source/Plugins/Process/elf-core/ThreadElfCore.h

lldb/source/Plugins/Process/elf-core/ThreadElfCore.cpp

clayborg · 2024-09-30T16:48:06Z

lldb/source/Plugins/Process/elf-core/ThreadElfCore.h

  int32_t si_errno;
+  int32_t si_code;
+  void *addr;       /* faulting insn/memory ref. */
+  int32_t addr_lsb; /* Valid LSB of the reported address.  */


Can we name this one as similar to the exact siginfo structure?

We can't use the si_ prefixed variables because siginfo_t.h defines these all as Macros in the global namespace, and I didn't want to couple our build to the existence of that macro

labath · 2024-10-01T13:33:59Z

Seems reasonable, but you'll need to use the signal constants from UnixSignals (looked up by string), as macros like SIGBUS might not exist (windows) or might not have the right value (macos). (NativeThreadLinux can get away with using them as it always runs on the host.)

You're referring to the properties in the ELFSignal object?

I'm referring to all of the places where you have case SIGSOMETHING in this patch. That's not good because the constant comes from the host, and it may be defined differently on the target. (or not defined at all).

labath · 2024-10-01T13:37:39Z

I actually tried to yamlize one of my test crash dumps. The issue I encountered was the PT_NOTE sections wasn't being generated with content. Is there a way with obj2yaml to generate PT_NOTES with content?

yaml2obj was originally written for llvm testing, so it mainly focuses on sections and other things that are interesting there. Support for program headers came later, and it's done on an on-demand and self-serve basis. Also, obj2yaml is generally in a better state than yaml2obj, so you may be able to use it to create the file you need, but you may need to write some yaml by hand.

github-actions · 2024-10-01T17:06:02Z

✅ With the latest revision this PR passed the C/C++ code formatter.

github-actions · 2024-10-01T20:22:18Z

✅ With the latest revision this PR passed the Python code formatter.

Jlalond · 2024-10-01T21:11:12Z

yaml2obj was originally written for llvm testing, so it mainly focuses on sections and other things that are interesting there. Support for program headers came later, and it's done on an on-demand and self-serve basis. Also, obj2yaml is generally in a better state than yaml2obj, so you may be able to use it to create the file you need, but you may need to write some yaml by hand.

I'm going to ignore my obj2yaml case here as we have some valid core tests that I updated. But I may tag in the future for obj2yaml to add content section to sufficiently small PT_Notes in the future!

labath · 2024-10-02T08:40:04Z

lldb/source/Plugins/Process/elf-core/ThreadElfCore.cpp

+static bool IsSignalWithAddrValue(int signo) {
+  // SIGILL, SIGFPE, SIGSEGV, SIGBUS, SIGTRAP
+  // We can't use the enum here because it may not be available on windows or
+  // other platforms. We should make an LLDB platform agnostic enum for this


We already have that. This data is encoded in the process->GetUnixSignals() object. You just need to plumb it to the right place.

labath · 2024-10-02T08:41:04Z

lldb/source/Plugins/Process/elf-core/ThreadElfCore.cpp

+
+std::string ELFLinuxSigInfo::GetDescription() {
+  if (IsSignalWithAddrValue(si_signo))
+    return lldb_private::UnixSignals::CreateForHost()->GetSignalDescription(


And this shouldn't be using the Host UnixSignals object for the same reason. Get the one from the Process instance.

clayborg · 2024-10-04T22:16:15Z

lldb/source/Plugins/Process/elf-core/ThreadElfCore.h

  int32_t si_errno;
+  int32_t si_code;
+  lldb::addr_t addr; /* faulting insn/memory ref. */
+  int32_t addr_lsb;  /* Valid LSB of the reported address.  */


Remove this if we aren't using it?

clayborg · 2024-10-04T22:21:14Z

lldb/source/Plugins/Process/elf-core/ThreadElfCore.h

  int32_t si_errno;
+  int32_t si_code;
+  lldb::addr_t addr; /* faulting insn/memory ref. */


name si_addr just like in the siginfo_t structure since the other names are using this convention. You might want to mirror more what the definition is by adding a anonymous union and then add the _sigfault entry to match the real definition.

I compiled in linux and this is what it looks like:

(siginfo_t) siginfo = { (int) si_signo = 0 (int) si_errno = 0 (int) si_code = 0 (int) __pad0 = 0 (siginfo_t::(unnamed union)) _sifields = { (int[28]) _pad = { (int) [0] = 0 (int) [1] = 0 (int) [2] = 0 (int) [3] = 0 (int) [4] = 0 (int) [5] = 0 (int) [6] = 0 (int) [7] = 0 (int) [8] = 0 (int) [9] = 0 (int) [10] = 0 (int) [11] = 0 (int) [12] = 0 (int) [13] = 0 (int) [14] = 0 (int) [15] = 0 (int) [16] = 0 (int) [17] = 0 (int) [18] = 0 (int) [19] = 0 (int) [20] = 0 (int) [21] = 0 (int) [22] = 0 (int) [23] = 0 (int) [24] = 0 (int) [25] = 0 (int) [26] = 0 (int) [27] = 0 } (siginfo_t::(unnamed struct)) _kill = { (__pid_t) si_pid = 0 (__uid_t) si_uid = 0 } (siginfo_t::(unnamed struct)) _timer = { (int) si_tid = 0 (int) si_overrun = 0 (__sigval_t) si_sigval = { (int) sival_int = 0 (void *) sival_ptr = 0x0000000000000000 } } (siginfo_t::(unnamed struct)) _rt = { (__pid_t) si_pid = 0 (__uid_t) si_uid = 0 (__sigval_t) si_sigval = { (int) sival_int = 0 (void *) sival_ptr = 0x0000000000000000 } } (siginfo_t::(unnamed struct)) _sigchld = { (__pid_t) si_pid = 0 (__uid_t) si_uid = 0 (int) si_status = 0 (__clock_t) si_utime = 0 (__clock_t) si_stime = 0 } (siginfo_t::(unnamed struct)) _sigfault = { (void *) si_addr = 0x0000000000000000 (short) si_addr_lsb = 0 (siginfo_t::(unnamed union)) _bounds = { (siginfo_t::(unnamed struct)) _addr_bnd = { (void *) _lower = 0x0000000000000000 (void *) _upper = 0x0000000000000000 } (__uint32_t) _pkey = 0 } } (siginfo_t::(unnamed struct)) _sigpoll = { (long) si_band = 0 (int) si_fd = 0 } (siginfo_t::(unnamed struct)) _sigsys = { (void *) _call_addr = 0x0000000000000000 (int) _syscall = 0 (unsigned int) _arch = 0 } } }

I'm going to have to disagree with Greg here. The internal layout of siginfo_t differs even for different linux architectures, so I don't think that matching any one particular system is doing to be helpful. Matching the exact layout also still wouldn't let us write things like our_siginfo.si_addr as that depends on the host macro, which will not be defined everywhere. (And it also would require using reserved identifiers)

The public interface (si_addr), is the same everywhere, so matching that would be better. Now, we can't use that name exactly, as it is a macro, but I we can use something that's closer to it. I'd suggest si_addr_, with a small comment that the other name is a macro.

Another thing I'd add here is that we now have (as in, we did not have it when this class was originally written), a way to get the siginfo_t definition precisely matching the os/architecture of the core file -- via Platform::GetSiginfoType(). I wouldn't say it's a requirement for this patch, but if you find yourself needing to match the exact layout of a siginfo struct, that's definitely the way I'd recommend. Since this is a CompilerType, it will take some refactoring to make it work with the code here, but the nice thing about it is that, once you have everything wired up, you will be able to dump the signal information for a thread with the thread siginfo command -- even if you don't have any debug information for the core file.

clayborg · 2024-10-04T22:21:55Z

lldb/source/Plugins/Process/elf-core/ThreadElfCore.cpp

+  // the unix_signals_sp->GetSignalDescription() call below.
+  if (unix_signals_sp->GetShouldStop(si_signo)) {
+    addr = data.GetAddress(&offset);
+    addr_lsb = data.GetU16(&offset);


remove addr_lsb if we don't use it.

labath · 2024-10-07T08:59:21Z

lldb/source/Plugins/Process/elf-core/ThreadElfCore.cpp

+    offset += 4;
+  // Not every stop signal has a valid address, but that will get resolved in
+  // the unix_signals_sp->GetSignalDescription() call below.
+  if (unix_signals_sp->GetShouldStop(si_signo)) {


GetShouldStop is called when determining whether we should automatically resume an application when it gets interrupted by a signal. Using it in a core file is.. unusual, as there is nothing to resume. What exactly are you trying to achieve here?

labath · 2024-10-07T09:12:56Z

lldb/source/Plugins/Process/elf-core/ThreadElfCore.h

  int32_t si_errno;
+  int32_t si_code;
+  lldb::addr_t addr; /* faulting insn/memory ref. */


I'm going to have to disagree with Greg here. The internal layout of siginfo_t differs even for different linux architectures, so I don't think that matching any one particular system is doing to be helpful. Matching the exact layout also still wouldn't let us write things like our_siginfo.si_addr as that depends on the host macro, which will not be defined everywhere. (And it also would require using reserved identifiers)

The public interface (si_addr), is the same everywhere, so matching that would be better. Now, we can't use that name exactly, as it is a macro, but I we can use something that's closer to it. I'd suggest si_addr_, with a small comment that the other name is a macro.

Another thing I'd add here is that we now have (as in, we did not have it when this class was originally written), a way to get the siginfo_t definition precisely matching the os/architecture of the core file -- via Platform::GetSiginfoType(). I wouldn't say it's a requirement for this patch, but if you find yourself needing to match the exact layout of a siginfo struct, that's definitely the way I'd recommend. Since this is a CompilerType, it will take some refactoring to make it work with the code here, but the nice thing about it is that, once you have everything wired up, you will be able to dump the signal information for a thread with the thread siginfo command -- even if you don't have any debug information for the core file.

labath · 2024-10-07T09:14:21Z

lldb/source/Plugins/Process/elf-core/ThreadElfCore.h

+                             const lldb::UnixSignalsSP unix_signals_sp);
+
+  std::string GetDescription(const lldb::UnixSignalsSP unix_signals_sp);


use const UnixSignals&. const lldb::UnixSignalsSP is a pointer to a mutable object, and you're not mutating it, nor storing long-term references to it.

clayborg · 2024-10-07T17:37:23Z

lldb/source/Plugins/Process/elf-core/ThreadElfCore.h

+  // Copied from siginfo_t so we don't have to include signal.h on non 'Nix
+  // builds, we add `g` to the si_ prefix because siginfo_t defines them as
+  // macros.
+  struct {


We should still make an anonymous union here for if/when we add more entries that overlap like in siginfo_t. Since this isn't C code, we should also put the _sigfault at the top:

union { struct _sigfault {

clayborg · 2024-10-07T17:37:45Z

lldb/source/Plugins/Process/elf-core/ThreadElfCore.h

+      /* used when si_code=SEGV_PKUERR */
+      uint32_t _pkey;
+    } _bounds;
+  } _sigfault;


remove name from the end of the struct sincde we are using C++.

Doesn't the name at the end of the struct denote it's also a member? I moved these to the top and then I then had to separately declare a member of my new struct type.

clayborg · 2024-10-07T17:38:44Z

lldb/source/Plugins/Process/elf-core/ThreadElfCore.h

+      } _addr_bnd;
+      /* used when si_code=SEGV_PKUERR */
+      uint32_t _pkey;
+    } _bounds;


move to top of union:

union _bounds {

clayborg · 2024-10-07T17:38:59Z

lldb/source/Plugins/Process/elf-core/ThreadElfCore.h

+      struct {
+        lldb::addr_t _lower;
+        lldb::addr_t _upper;
+      } _addr_bnd;


move to struct line:

struct _addr_bnd;

clayborg · 2024-10-07T17:42:51Z

lldb/source/Plugins/Process/elf-core/ThreadElfCore.h

  int signo = 0;
  int code = 0;
  int prstatus_sig = 0;
+  std::string description;


We might be able to remove all of these and just replace these with a lldb::StopInfoSP and always either create a lldb::StopInfoSP for the thread when we create the thread instead of duplicating info from the siginfo_t struct here, we don't want to keep adding more fields here in the future.

I'm going to lightly push back on this. ProcessElfCore currently depends a lot on threaddata, not just for populating the thread but for some ELF specific logic.

I think what we could do is forego having ELFSigInfo populate itself and instead directly populate threaddata, which prevents us from double allocating, then we can have ThreadElfCore continue creating a StopInfoSP in CalculateStopInfo.

clayborg · 2024-10-07T17:44:07Z

lldb/source/Plugins/Process/elf-core/ThreadElfCore.h

  int m_signo;
  int m_code;
+  std::string m_sig_description;



See lldb::StopInfoSP comment above. We seem to be duplicating info from the siginto_t struct in both the ThreadData and in the ThreadELFCore classes.

… and rework parsing and description generating code

…e read 0 from NT_SIGINFO

sylvestre · 2024-11-22T14:09:38Z

@Jlalond it breaks the build on i386 on:
#117327

tuliom · 2024-11-25T12:09:07Z

We're also seeing this issue.
We have a full build log available at https://download.copr.fedorainfracloud.org/results/@fedora-llvm-team/llvm-snapshots-big-merge-20241123/fedora-rawhide-i386/08305565-llvm/builder-live.log.gz , in case it helps.

Jlalond · 2024-11-25T18:00:36Z

Ack, sorry about the delay. I will get this fixed today.

…non build dependent size (#117604) On #110065 the changes to LinuxSigInfo Struct introduced some variables that will differ in size on 32b or 64b. I've rectified this by setting them all to build independent types.

Jlalond requested a review from clayborg September 26, 2024 00:46

Jlalond requested a review from JDevlieghere as a code owner September 26, 2024 00:46

llvmbot added the lldb label Sep 26, 2024

clayborg requested changes Sep 30, 2024

View reviewed changes

labath reviewed Oct 2, 2024

View reviewed changes

Jlalond force-pushed the fully-parse-unix-signals branch from 8d0f382 to e98ac53 Compare October 3, 2024 18:51

clayborg reviewed Oct 4, 2024

View reviewed changes

labath reviewed Oct 7, 2024

View reviewed changes

Jlalond force-pushed the fully-parse-unix-signals branch from 397f094 to acbc3a0 Compare October 7, 2024 17:22

clayborg reviewed Oct 7, 2024

View reviewed changes

Jlalond added 8 commits October 9, 2024 13:16

Add the addr info when appropriate for NIX' crash signals

ce87c9d

Drop test as we can't yamilize the pt_note content

ebc02c4

Run GCF

d17c412

remove addr from threaddata

f9e5cee

Refactor to not depend ont the SIG enums, and use lldb::addr_t

c3691a8

Fix tests for the entire string and run GCF

2598427

Python formatting

b6b46ae

Use unix signals from process instead of reinventing the wheel

2eec5fb

Jlalond added 5 commits October 9, 2024 13:16

Drop reinterpret cast

4a225c9

Copy the siginfo_t structure with as minimal differences as possible,…

4cacf29

… and rework parsing and description generating code

Switch to const reference

202b768

Start migrating away from threaddata containing the signal data

babd0e1

Move all the ELF Nix' flavors to the SigInfo, but don't emit unless w…

a4b7b3f

…e read 0 from NT_SIGINFO

Jlalond force-pushed the fully-parse-unix-signals branch from 65c3d18 to a4b7b3f Compare October 9, 2024 20:17

clayborg approved these changes Nov 12, 2024

View reviewed changes

Jlalond merged commit 0a72429 into llvm:main Nov 21, 2024
7 checks passed

Jlalond mentioned this pull request Nov 25, 2024

[LLDB][ThreadELFCore] Set all the properties of ELFLinuxSigInfo to a non build dependent size #117604

Merged

Jlalond deleted the fully-parse-unix-signals branch March 7, 2025 19:20

		const lldb::UnixSignalsSP unix_signals_sp);

		std::string GetDescription(const lldb::UnixSignalsSP unix_signals_sp);

[LLDB][ProcessELFCore] Add Description to ProcessELFCore/ELFThread stop reasons #110065

[LLDB][ProcessELFCore] Add Description to ProcessELFCore/ELFThread stop reasons #110065

Uh oh!

Conversation

Jlalond commented Sep 26, 2024

Uh oh!

llvmbot commented Sep 26, 2024

Uh oh!

Jlalond commented Sep 26, 2024

Uh oh!

DavidSpickett commented Sep 27, 2024

Uh oh!

labath commented Sep 27, 2024

Uh oh!

DavidSpickett commented Sep 27, 2024

Uh oh!

Jlalond commented Sep 27, 2024

Uh oh!

Jlalond commented Sep 27, 2024

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

labath commented Oct 1, 2024

Uh oh!

labath commented Oct 1, 2024

Uh oh!

github-actions bot commented Oct 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jlalond commented Oct 1, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sylvestre commented Nov 22, 2024

Uh oh!

tuliom commented Nov 25, 2024

Uh oh!

Jlalond commented Nov 25, 2024

Uh oh!

Uh oh!

github-actions bot commented Oct 1, 2024 •

edited

Loading

github-actions bot commented Oct 1, 2024 •

edited

Loading