Skip to content

[MCParser] Avoid repeated hash lookups (NFC) #110204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kazutakahirata
Copy link
Contributor

No description provided.

@llvmbot llvmbot added the mc Machine (object) code label Sep 27, 2024
@llvmbot
Copy link
Member

llvmbot commented Sep 27, 2024

@llvm/pr-subscribers-mc

Author: Kazu Hirata (kazutakahirata)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/110204.diff

1 Files Affected:

  • (modified) llvm/lib/MC/MCParser/MasmParser.cpp (+1-3)
diff --git a/llvm/lib/MC/MCParser/MasmParser.cpp b/llvm/lib/MC/MCParser/MasmParser.cpp
index c5ff1e7acbfd2a..d88fd09a1aa07c 100644
--- a/llvm/lib/MC/MCParser/MasmParser.cpp
+++ b/llvm/lib/MC/MCParser/MasmParser.cpp
@@ -479,9 +479,7 @@ class MasmParser : public MCAsmParser {
   void addDirectiveHandler(StringRef Directive,
                            ExtensionDirectiveHandler Handler) override {
     ExtensionDirectiveMap[Directive] = Handler;
-    if (!DirectiveKindMap.contains(Directive)) {
-      DirectiveKindMap[Directive] = DK_HANDLER_DIRECTIVE;
-    }
+    DirectiveKindMap.try_emplace(Directive, DK_HANDLER_DIRECTIVE);
   }
 
   void addAliasForDirective(StringRef Directive, StringRef Alias) override {

@kazutakahirata kazutakahirata force-pushed the cleanup_001_repeated_hash_MasmParser branch 2 times, most recently from f4a5182 to 701a0e6 Compare September 28, 2024 00:17
@kazutakahirata kazutakahirata force-pushed the cleanup_001_repeated_hash_MasmParser branch from 701a0e6 to 82934fa Compare September 28, 2024 08:22
@kazutakahirata kazutakahirata merged commit 5bc673d into llvm:main Sep 28, 2024
6 of 8 checks passed
@kazutakahirata kazutakahirata deleted the cleanup_001_repeated_hash_MasmParser branch September 28, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mc Machine (object) code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants