[StandardInstrumentations] Ensure non-null module pointer when getting display name for IR file #110779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g display name for IR file Fixes a crash when using -filter-print-funcs with -ir-dump-directory.
duk-37
force-pushed
the
force-module-for-display-name
branch
from
2e3fe7c to
2c8c0d3
Compare
aeubanks
approved these changes
Oct 2, 2024
| @@ -0,0 +1,14 @@ | |||
| ;; Make sure we can run -filter-print-funcs with -ir-dump-directory. | |||
| ; RUN: rm -rf %t/logs | |||
There was a problem hiding this comment.
do we need to mkdir %t/logs?
There was a problem hiding this comment.
It's automatically generated by -ir-dump-directory, so I don't think so.
|
FYI I don't have commit access for the time being, so if this looks good it'd be great if you could merge it in @aeubanks :) |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/4788 Here is the relevant piece of the build log for the reference |
Sterling-Augustine
pushed a commit
to Sterling-Augustine/llvm-project
that referenced
this pull request
Oct 3, 2024
…g display name for IR file (llvm#110779) Fixes a crash when using `-filter-print-funcs` with `-ir-dump-directory`. A quick reproducer on trunk (also included as a test): ```ll ; opt -passes=no-op-function -print-after=no-op-function -filter-print-funcs=nope -ir-dump-directory=somewhere test.ll define void @test() { ret void } ``` [Compiler Explorer](https://godbolt.org/z/sPErz44h4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a crash when using
-filter-print-funcswith-ir-dump-directory. A quick reproducer on trunk (also included as a test):Compiler Explorer