[libclc] Update build instructions in readme #111369
Conversation
The configure Python script was removed by d6e0e6d / https://reviews.llvm.org/D69966. The readme was never updated with the cmake way to do it. I couldn't find any dedicated buildbots for this so I'm making an educated guess. This is what built locally for me.
|
One "andrew-podko" did request this get updated but that was in October 2020, so I expect they're not around anymore. |
|
Also do you know if libclc has any tests worth running in CI? It doesn't have a check-libclc so I'm not sure if that's because there's not much to run, or running the tests requires a GPU or something else. Context is I've been looking at the pipeline we use for PRs and it doesn't know what to do with libclc so it uses check-all, ideally it would have a specific target because check-all can lead to us running more tests than we need to. |
No, there aren't any tests. Well I think there are some I did start adding some tests in #87989 but didn't get very far before I switched focus. Part of the problem is that it can be built out of tree, or with an unknown version of clang, and it's hard to know what other downstreams are doing with it. |
|
Thankyou! So I think in CI we can not add any extra testing targets if libclc is included in the build. If you have some in future I'm happy to help enable them. |
According to llvm#111369 (comment) there is no testing to be done here. Adding "check-all" only risks duplicating tests if other project specific "check-" targets are also added.
According to #111369 (comment) there is no testing to be done here. Adding "check-all" only risks duplicating tests if other project specific "check-" targets are also added.
The configure Python script was removed by
d6e0e6d / https://reviews.llvm.org/D69966.
The readme was never updated with the cmake way to do it. I couldn't find any dedicated buildbots for this so I'm making an educated guess. This is what built locally for me.