Skip to content

[libc++] Remove nonexistent directory from check-generated-output #111746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

ldionne
Copy link
Member

@ldionne ldionne commented Oct 9, 2024

The libcxx/benchmarks directory was moved to libcxx/test/benchmarks, which is already checked by that grep command.

The libcxx/benchmarks directory was moved to libcxx/test/benchmarks,
which is already checked by that grep command.
@ldionne ldionne requested a review from a team as a code owner October 9, 2024 19:09
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Oct 9, 2024
@llvmbot
Copy link
Member

llvmbot commented Oct 9, 2024

@llvm/pr-subscribers-libcxx

Author: Louis Dionne (ldionne)

Changes

The libcxx/benchmarks directory was moved to libcxx/test/benchmarks, which is already checked by that grep command.


Full diff: https://github.com/llvm/llvm-project/pull/111746.diff

1 Files Affected:

  • (modified) libcxx/utils/ci/run-buildbot (+1-1)
diff --git a/libcxx/utils/ci/run-buildbot b/libcxx/utils/ci/run-buildbot
index 536d6270361307..0ce1def5f37224 100755
--- a/libcxx/utils/ci/run-buildbot
+++ b/libcxx/utils/ci/run-buildbot
@@ -238,7 +238,7 @@ check-generated-output)
     # Reject patches that introduce non-ASCII characters or hard tabs.
     # Depends on LC_COLLATE set at the top of this script.
     set -x
-    ! grep -rn '[^ -~]' libcxx/include libcxx/src libcxx/test libcxx/benchmarks \
+    ! grep -rn '[^ -~]' libcxx/include libcxx/src libcxx/test \
            --exclude '*.dat' \
            --exclude '*unicode*.cpp' \
            --exclude '*print*.sh.cpp' \

@ldionne ldionne merged commit ea2b897 into llvm:main Oct 10, 2024
67 checks passed
@ldionne ldionne deleted the review/generated-output-non-ascii branch October 10, 2024 11:57
DanielCChen pushed a commit to DanielCChen/llvm-project that referenced this pull request Oct 16, 2024
…vm#111746)

The libcxx/benchmarks directory was moved to libcxx/test/benchmarks,
which is already checked by that grep command.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants