[lldb] Narrow scope of -Wno-deprecated-declarations (NFC) #112276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently all of LLDB is being compiled with -Wno-deprecated-declarations. That's not desirable, especially as part of the LLVM monorepo, as we miss deprecation warnings from LLVM and clang. According to the git history, this was first introduced to suppress warnings related to auto_ptr. Since then, other things have been deprecated and gone unnoticed. This patch limits the flag to Host.mm which uses a handful of LSApplication headers that have no replacement. rdar://112040718
JDevlieghere
added a commit
to JDevlieghere/llvm-project
that referenced
this pull request
Oct 15, 2024
Disable -Wdeprecated-declarations for codecvt_utf8 in Editline. This is in preparation for llvm#112276 which narrows the scope of -Wno-deprecated-declarations for building LLDB.
|
@llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) ChangesCurrently all of LLDB is being compiled with -Wno-deprecated-declarations. That's not desirable, especially as part of the LLVM monorepo, as we miss deprecation warnings from LLVM and clang. According to the git history, this was first introduced to suppress warnings related to auto_ptr. Since then, other things have been deprecated and gone unnoticed. This patch limits the flag to Host.mm which uses a handful of LSApplication headers that have no replacement. rdar://112040718 Full diff: https://github.com/llvm/llvm-project/pull/112276.diff 2 Files Affected:
diff --git a/lldb/cmake/modules/LLDBConfig.cmake b/lldb/cmake/modules/LLDBConfig.cmake
index a60921990cf775..93ccd9c479c2b8 100644
--- a/lldb/cmake/modules/LLDBConfig.cmake
+++ b/lldb/cmake/modules/LLDBConfig.cmake
@@ -188,7 +188,6 @@ include_directories("${CMAKE_CURRENT_BINARY_DIR}/../clang/include")
if (LLVM_COMPILER_IS_GCC_COMPATIBLE)
# Disable GCC warnings
- append("-Wno-deprecated-declarations" CMAKE_CXX_FLAGS)
append("-Wno-unknown-pragmas" CMAKE_CXX_FLAGS)
append("-Wno-strict-aliasing" CMAKE_CXX_FLAGS)
@@ -198,7 +197,6 @@ endif()
# Disable Clang warnings
if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
- append("-Wno-deprecated-register" CMAKE_CXX_FLAGS)
append("-Wno-vla-extension" CMAKE_CXX_FLAGS)
endif()
diff --git a/lldb/source/Host/macosx/objcxx/CMakeLists.txt b/lldb/source/Host/macosx/objcxx/CMakeLists.txt
index 273999f24380e5..1e693bed12ce15 100644
--- a/lldb/source/Host/macosx/objcxx/CMakeLists.txt
+++ b/lldb/source/Host/macosx/objcxx/CMakeLists.txt
@@ -16,4 +16,6 @@ add_lldb_library(lldbHostMacOSXObjCXX NO_PLUGIN_DEPENDENCIES
TargetParser
)
-target_compile_options(lldbHostMacOSXObjCXX PRIVATE -fno-objc-exceptions)
+target_compile_options(lldbHostMacOSXObjCXX PRIVATE
+ -fno-objc-exceptions
+ -Wno-deprecated-declarations)
|
labath
approved these changes
Oct 16, 2024
JDevlieghere
added a commit
that referenced
this pull request
Oct 17, 2024
Disable -Wdeprecated-declarations for codecvt_utf8 in Editline. This is in preparation for #112276 which narrows the scope of -Wno-deprecated-declarations for building LLDB.
JDevlieghere
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Oct 22, 2024
) Disable -Wdeprecated-declarations for codecvt_utf8 in Editline. This is in preparation for llvm#112276 which narrows the scope of -Wno-deprecated-declarations for building LLDB. (cherry picked from commit 8c7f80f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all of LLDB is being compiled with -Wno-deprecated-declarations. That's not desirable, especially as part of the LLVM monorepo, as we miss deprecation warnings from LLVM and clang.
According to the git history, this was first introduced to suppress warnings related to auto_ptr. Since then, other things have been deprecated and gone unnoticed. This patch limits the flag to Host.mm which uses a handful of LSApplication headers that have no replacement.
rdar://112040718