[PAC][lld] Test warning emitted for non-PAuth-marked files with -z pac-plt
#112958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-lld @llvm/pr-subscribers-lld-elf Author: Daniil Kovalev (kovdan01) Changesb616262 changed semantics of > There are no warnings in this case as the choice to use PAC in PLT entries This patch updates the test so we ensure a warning is emitted for an Full diff: https://github.com/llvm/llvm-project/pull/112958.diff 1 Files Affected:
diff --git a/lld/test/ELF/aarch64-feature-pac.s b/lld/test/ELF/aarch64-feature-pac.s
index beafe58887db3f..b85a33216cb5bd 100644
--- a/lld/test/ELF/aarch64-feature-pac.s
+++ b/lld/test/ELF/aarch64-feature-pac.s
@@ -76,12 +76,14 @@
# PACDYN-NOT: 0x0000000070000001 (AARCH64_BTI_PLT)
# PACDYN-NOT: 0x0000000070000003 (AARCH64_PAC_PLT)
-## Turn on PAC entries with the -z pac-plt command line option. There are no
-## warnings in this case as the choice to use PAC in PLT entries is orthogonal
-## to the choice of using PAC in relocatable objects. The presence of the PAC
-## .note.gnu.property is an indication of preference by the relocatable object.
+## Turn on PAC entries with the -z pac-plt command line option. For files w/o
+## GNU_PROPERTY_AARCH64_FEATURE_1_PAC set in GNU_PROPERTY_AARCH64_FEATURE_1_AND
+## property, emit a warning.
+
+# RUN: ld.lld %t.o %t2.o -z pac-plt %t.so -o %tpacplt.exe 2>&1 | FileCheck -DFILE=%t2.o --check-prefix WARN %s
+
+# WARN: warning: [[FILE]]: -z pac-plt: file does not have GNU_PROPERTY_AARCH64_FEATURE_1_PAC property
-# RUN: ld.lld %t.o %t2.o -z pac-plt %t.so -o %tpacplt.exe
# RUN: llvm-readelf -n %tpacplt.exe | FileCheck --check-prefix=PACPROP %s
# RUN: llvm-readelf --dynamic-table %tpacplt.exe | FileCheck --check-prefix PACDYN2 %s
# RUN: llvm-objdump --no-print-imm-hex -d --mattr=+v8.3a --no-show-raw-insn %tpacplt.exe | FileCheck --check-prefix PACPLT %s
|
|
Would be glad to see everyone's feedback on the changes. |
…ac-plt` b616262 changed semantics of `-z pac-plt` initially introduced in e208208, so, the following comment from test/ELF/aarch64-feature-pac.s is no longer true: > There are no warnings in this case as the choice to use PAC in PLT entries > is orthogonal to the choice of using PAC in relocatable objects. The > presence of the PAC .note.gnu.property is an indication of preference by > the relocatable object. This patch updates the test so we ensure a warning is emitted for an input file when `-z pac-plt` is passed but the file does not have GNU_PROPERTY_AARCH64_FEATURE_1_PAC set in GNU_PROPERTY_AARCH64_FEATURE_1_AND property.
kovdan01
force-pushed
the
users/kovdan01/lld-pac-plt-warning
branch
from
51235d7 to
ceefe60
Compare
|
LGTM |
Groverkss
pushed a commit
to iree-org/llvm-project
that referenced
this pull request
Nov 15, 2024
…ac-plt` (llvm#112958) b616262 changed semantics of `-z pac-plt` initially introduced in e208208, so, the following comment from test/ELF/aarch64-feature-pac.s is no longer true: > There are no warnings in this case as the choice to use PAC in PLT entries > is orthogonal to the choice of using PAC in relocatable objects. The > presence of the PAC .note.gnu.property is an indication of preference by > the relocatable object. This patch updates the test so we ensure a warning is emitted for an input file when `-z pac-plt` is passed but the file does not have GNU_PROPERTY_AARCH64_FEATURE_1_PAC set in GNU_PROPERTY_AARCH64_FEATURE_1_AND property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b616262 changed semantics of
-z pac-pltinitially introduced ine208208, so, the following comment from test/ELF/aarch64-feature-pac.s
is no longer true:
This patch updates the test so we ensure a warning is emitted for an
input file when
-z pac-pltis passed but the file does not haveGNU_PROPERTY_AARCH64_FEATURE_1_PAC set in GNU_PROPERTY_AARCH64_FEATURE_1_AND
property.