Skip to content

[libc][bazel] Fix linter warning - remove unused load. #114493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

vonosmas
Copy link
Contributor

@vonosmas vonosmas commented Nov 1, 2024

This load is no longer necessary since PLATFORM_CPU_ARM64 was removed in fa17977

@llvmbot llvmbot added libc bazel "Peripheral" support tier build system: utils/bazel labels Nov 1, 2024
@llvmbot
Copy link
Member

llvmbot commented Nov 1, 2024

@llvm/pr-subscribers-libc

Author: Alexey Samsonov (vonosmas)

Changes

This load is no longer necessary since PLATFORM_CPU_ARM64 was removed in fa17977


Full diff: https://github.com/llvm/llvm-project/pull/114493.diff

1 Files Affected:

  • (modified) utils/bazel/llvm-project-overlay/libc/libc_build_rules.bzl (+1-1)
diff --git a/utils/bazel/llvm-project-overlay/libc/libc_build_rules.bzl b/utils/bazel/llvm-project-overlay/libc/libc_build_rules.bzl
index f298f817af83d7..9dc25f95b8e3f1 100644
--- a/utils/bazel/llvm-project-overlay/libc/libc_build_rules.bzl
+++ b/utils/bazel/llvm-project-overlay/libc/libc_build_rules.bzl
@@ -8,7 +8,7 @@ load("@bazel_skylib//lib:paths.bzl", "paths")
 load("@bazel_skylib//lib:selects.bzl", "selects")
 load(":libc_configure_options.bzl", "LIBC_CONFIGURE_OPTIONS")
 load(":libc_namespace.bzl", "LIBC_NAMESPACE")
-load(":platforms.bzl", "PLATFORM_CPU_ARM64", "PLATFORM_CPU_X86_64")
+load(":platforms.bzl", "PLATFORM_CPU_X86_64")
 
 def libc_internal_target(name):
     return name + ".__internal__"

@vonosmas vonosmas merged commit 33d636f into llvm:main Nov 1, 2024
8 checks passed
@vonosmas vonosmas deleted the buildifier branch November 1, 2024 00:35
smallp-o-p pushed a commit to smallp-o-p/llvm-project that referenced this pull request Nov 3, 2024
This load is no longer necessary since PLATFORM_CPU_ARM64 was removed in
fa17977
NoumanAmir657 pushed a commit to NoumanAmir657/llvm-project that referenced this pull request Nov 4, 2024
This load is no longer necessary since PLATFORM_CPU_ARM64 was removed in
fa17977
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bazel "Peripheral" support tier build system: utils/bazel libc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants