Skip to content

[llvm-(min-)tblgen] Avoid redundant source compilation #114494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 2, 2025
Merged

[llvm-(min-)tblgen] Avoid redundant source compilation #114494

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
94dd647
[llvm-(min-)tblgen] Avoid redundant source compilation
Meinersbur Nov 1, 2024
a35bd89
No additional object library necessary
Meinersbur Nov 1, 2024
3234b52
Revert "No additional object library necessary"
Meinersbur Nov 4, 2024
4d31243
Move common files to TabeGenBasic
Meinersbur Nov 4, 2024
d79ea2f
Merge branch 'main' into llvm_tblgen_both
Meinersbur Dec 6, 2024
69092f8
Merge branch 'main' into llvm_tblgen_both
Meinersbur Dec 16, 2024
db0cafc
Apply @chapuni's suggestion
Meinersbur Dec 16, 2024
640a872
Keep TableGen.cpp filename
Meinersbur Dec 16, 2024
52c41a6
Merge branch 'main' into llvm_tblgen_both
Meinersbur Jan 2, 2025
a1849e6
Fix double use of llvm-min-tblgen.cpp
Meinersbur Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions llvm/utils/TableGen/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,8 @@ set(LLVM_LINK_COMPONENTS
add_tablegen(llvm-tblgen LLVM
DESTINATION "${LLVM_TOOLS_INSTALL_DIR}"
EXPORT LLVM
ARMTargetDefEmitter.cpp
AsmMatcherEmitter.cpp
AsmWriterEmitter.cpp
Attributes.cpp
CallingConvEmitter.cpp
CodeEmitterGen.cpp
CodeGenMapTable.cpp
Expand All @@ -48,7 +46,6 @@ add_tablegen(llvm-tblgen LLVM
DecoderEmitter.cpp
DFAEmitter.cpp
DFAPacketizerEmitter.cpp
DirectiveEmitter.cpp
DisassemblerEmitter.cpp
DXILEmitter.cpp
ExegesisEmitter.cpp
Expand All @@ -57,25 +54,23 @@ add_tablegen(llvm-tblgen LLVM
GlobalISelEmitter.cpp
InstrDocsEmitter.cpp
InstrInfoEmitter.cpp
IntrinsicEmitter.cpp
MacroFusionPredicatorEmitter.cpp
OptionParserEmitter.cpp
OptionRSTEmitter.cpp
PseudoLoweringEmitter.cpp
RegisterBankEmitter.cpp
RegisterInfoEmitter.cpp
RISCVTargetDefEmitter.cpp
SearchableTableEmitter.cpp
SubtargetEmitter.cpp
TableGen.cpp
VTEmitter.cpp
WebAssemblyDisassemblerEmitter.cpp
X86InstrMappingEmitter.cpp
X86DisassemblerTables.cpp
X86FoldTablesEmitter.cpp
X86MnemonicTables.cpp
X86ModRMFilters.cpp
X86RecognizableInstr.cpp

$<TARGET_OBJECTS:llvm-min-tblgen>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wouldn't work. Look into 137d803.
Restoring part of 137d803 may be an option.

Copy link
Member Author

@Meinersbur Meinersbur Nov 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a35bd89 I created another OBJECT library. Do you think it should be merge into TableGenBasic?

Copy link
Member Author

@Meinersbur Meinersbur Nov 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the latter, should the "both" files moved into the Basic/ subdir?

$<TARGET_OBJECTS:obj.LLVMTableGenBasic>
$<TARGET_OBJECTS:obj.LLVMTableGenCommon>

Expand Down
Loading