Skip to content

[libc] disable failing include tests #114619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

nickdesaulniers
Copy link
Member

These are failing to link for some buildbots. It's not immediately clear why,
disable these and add a todo to investigate.

Link: #111403
Link: #114566
Link: #114618

These are failing to link for some buildbots. It's not immediately clear why,
disable these and add a todo to investigate.

Link: llvm#111403
Link: llvm#114566
Link: llvm#114618
@llvmbot
Copy link
Member

llvmbot commented Nov 1, 2024

@llvm/pr-subscribers-libc

Author: Nick Desaulniers (nickdesaulniers)

Changes

These are failing to link for some buildbots. It's not immediately clear why,
disable these and add a todo to investigate.

Link: #111403
Link: #114566
Link: #114618


Full diff: https://github.com/llvm/llvm-project/pull/114619.diff

1 Files Affected:

  • (modified) libc/test/include/CMakeLists.txt (+36-35)
diff --git a/libc/test/include/CMakeLists.txt b/libc/test/include/CMakeLists.txt
index 146e43e580670b..ba21a69a31a3b4 100644
--- a/libc/test/include/CMakeLists.txt
+++ b/libc/test/include/CMakeLists.txt
@@ -372,41 +372,42 @@ add_libc_test(
     libc.include.llvm-libc-macros.math_function_macros
 )
 
-add_libc_test(
-  issignaling_c_test
-  C_TEST
-  UNIT_TEST_ONLY
-  SUITE
-    libc_include_tests
-  SRCS
-    issignaling_test.c
-  COMPILE_OPTIONS
-    -Wall
-    -Werror
-  DEPENDS
-    libc.include.llvm-libc-macros.math_function_macros
-    libc.src.math.issignaling
-    libc.src.math.issignalingf
-    libc.src.math.issignalingl
-)
-
-add_libc_test(
-  iscanonical_c_test
-  C_TEST
-  UNIT_TEST_ONLY
-  SUITE
-    libc_include_tests
-  SRCS
-    iscanonical_test.c
-  COMPILE_OPTIONS
-    -Wall
-    -Werror
-  DEPENDS
-    libc.include.llvm-libc-macros.math_function_macros
-    libc.src.math.iscanonical
-    libc.src.math.iscanonicalf
-    libc.src.math.iscanonicall
-)
+# TODO(https://github.com/llvm/llvm-project/issues/114618): fix linkage failures
+# add_libc_test(
+#   issignaling_c_test
+#   C_TEST
+#   UNIT_TEST_ONLY
+#   SUITE
+#     libc_include_tests
+#   SRCS
+#     issignaling_test.c
+#   COMPILE_OPTIONS
+#     -Wall
+#     -Werror
+#   DEPENDS
+#     libc.include.llvm-libc-macros.math_function_macros
+#     libc.src.math.issignaling
+#     libc.src.math.issignalingf
+#     libc.src.math.issignalingl
+# )
+
+# add_libc_test(
+#   iscanonical_c_test
+#   C_TEST
+#   UNIT_TEST_ONLY
+#   SUITE
+#     libc_include_tests
+#   SRCS
+#     iscanonical_test.c
+#   COMPILE_OPTIONS
+#     -Wall
+#     -Werror
+#   DEPENDS
+#     libc.include.llvm-libc-macros.math_function_macros
+#     libc.src.math.iscanonical
+#     libc.src.math.iscanonicalf
+#     libc.src.math.iscanonicall
+# )
 
 add_libc_test(
   isinf_c_test

@nickdesaulniers nickdesaulniers merged commit 89560cd into llvm:main Nov 1, 2024
6 of 7 checks passed
@nickdesaulniers nickdesaulniers deleted the disable_tests branch November 1, 2024 22:33
smallp-o-p pushed a commit to smallp-o-p/llvm-project that referenced this pull request Nov 3, 2024
These are failing to link for some buildbots. It's not immediately clear
why,
disable these and add a todo to investigate.

Link: llvm#111403
Link: llvm#114566
Link: llvm#114618
NoumanAmir657 pushed a commit to NoumanAmir657/llvm-project that referenced this pull request Nov 4, 2024
These are failing to link for some buildbots. It's not immediately clear
why,
disable these and add a todo to investigate.

Link: llvm#111403
Link: llvm#114566
Link: llvm#114618
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants