Comment out CF16 entrypoints for aarch64 and CF128 entrypoints for X84-64 #114696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sh0g0-1758
changed the title
|
@llvm/pr-subscribers-libc Author: Shourya Goel (Sh0g0-1758) ChangesTemporarily Fixes buildbot errors due to #113300 Full diff: https://github.com/llvm/llvm-project/pull/114696.diff 2 Files Affected:
diff --git a/libc/config/linux/aarch64/entrypoints.txt b/libc/config/linux/aarch64/entrypoints.txt
index 9f076ddedb5c67..3e263b50327f2e 100644
--- a/libc/config/linux/aarch64/entrypoints.txt
+++ b/libc/config/linux/aarch64/entrypoints.txt
@@ -612,8 +612,8 @@ set(TARGET_LIBM_ENTRYPOINTS
if(LIBC_TYPES_HAS_FLOAT16)
list(APPEND TARGET_LIBM_ENTRYPOINTS
# complex.h C23 _Complex _Float16 entrypoints
- libc.src.complex.crealf16
- libc.src.complex.cimagf16
+ # libc.src.complex.crealf16
+ # libc.src.complex.cimagf16
# math.h C23 _Float16 entrypoints
libc.src.math.canonicalizef16
diff --git a/libc/config/linux/x86_64/entrypoints.txt b/libc/config/linux/x86_64/entrypoints.txt
index af9b41eb40e32d..3ed77c76709da8 100644
--- a/libc/config/linux/x86_64/entrypoints.txt
+++ b/libc/config/linux/x86_64/entrypoints.txt
@@ -722,8 +722,8 @@ endif()
if(LIBC_TYPES_HAS_FLOAT128)
list(APPEND TARGET_LIBM_ENTRYPOINTS
# complex.h C23 _Complex _Float128 entrypoints
- libc.src.complex.crealf128
- libc.src.complex.cimagf128
+ # libc.src.complex.crealf128
+ # libc.src.complex.cimagf128
# math.h C23 _Float128 entrypoints
libc.src.math.canonicalizef128
|
lntue
approved these changes
Nov 3, 2024
NoumanAmir657
pushed a commit
to NoumanAmir657/llvm-project
that referenced
this pull request
Nov 4, 2024
…4-64 (llvm#114696) Temporarily Fixes buildbot errors due to llvm#113300
PhilippRados
pushed a commit
to PhilippRados/llvm-project
that referenced
this pull request
Nov 6, 2024
…4-64 (llvm#114696) Temporarily Fixes buildbot errors due to llvm#113300
Sh0g0-1758
added a commit
that referenced
this pull request
Dec 26, 2024
Proper fix for the temporary fix in #114696
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily Fixes buildbot errors due to #113300