Skip to content

Nominate Saleem and myself as maintainers for API Notes #114981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

egorzhdan
Copy link
Contributor

Saleem has upstreamed a large chunk of API Notes infrastructure from the Apple fork, and over the past year I've upstreamed the remaining part of API Notes, added new annotations and improved C++ language support.

https://github.com/llvm/llvm-project/commits/main/clang/lib/APINotes

@llvmbot llvmbot added the clang Clang issues not falling into any other category label Nov 5, 2024
@llvmbot
Copy link
Member

llvmbot commented Nov 5, 2024

@llvm/pr-subscribers-clang

Author: Egor Zhdan (egorzhdan)

Changes

Saleem has upstreamed a large chunk of API Notes infrastructure from the Apple fork, and over the past year I've upstreamed the remaining part of API Notes, added new annotations and improved C++ language support.

https://github.com/llvm/llvm-project/commits/main/clang/lib/APINotes


Full diff: https://github.com/llvm/llvm-project/pull/114981.diff

1 Files Affected:

  • (modified) clang/Maintainers.rst (+8)
diff --git a/clang/Maintainers.rst b/clang/Maintainers.rst
index 694ebc691107cb..0fcbbbf31005e7 100644
--- a/clang/Maintainers.rst
+++ b/clang/Maintainers.rst
@@ -132,6 +132,14 @@ Compiler options
 | jan_svoboda\@apple.com (email), jansvoboda11 (Phabricator), jansvoboda11 (GitHub)
 
 
+API Notes
+~~~~~~~~~~~~~~~~
+| Egor Zhdan
+| e_zhdan\@apple.com (email), egorzhdan (GitHub), egor.zhdan (Discourse)
+
+| Saleem Abdulrasool
+| [email protected] (email), compnerd (GitHub), compnerd (Discourse)
+
 OpenBSD driver
 ~~~~~~~~~~~~~~
 | Brad Smith

@egorzhdan egorzhdan force-pushed the users/egorzhdan/apinotes-maintainers branch from 77be63c to 1bf3932 Compare November 5, 2024 13:08
Copy link
Collaborator

@AaronBallman AaronBallman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (with a minor whitespace nit for consistency with the rest of the file), though please wait to land until after @compnerd has accepted the nomination as well.

Thank you for volunteering!

Co-authored-by: Aaron Ballman <[email protected]>
@compnerd
Copy link
Member

compnerd commented Nov 5, 2024

Thanks @AaronBallman - @egorzhdan was nice enough to reach out to me earlier and I am fine with co-maintaining the APINotes.

@AaronBallman AaronBallman merged commit 44c279c into main Nov 5, 2024
8 checks passed
@AaronBallman AaronBallman deleted the users/egorzhdan/apinotes-maintainers branch November 5, 2024 16:27
PhilippRados pushed a commit to PhilippRados/llvm-project that referenced this pull request Nov 6, 2024
Saleem has upstreamed a large chunk of API Notes infrastructure from the
Apple fork, and over the past year I've upstreamed the remaining part of
API Notes, added new annotations and improved C++ language support.

https://github.com/llvm/llvm-project/commits/main/clang/lib/APINotes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants