Skip to content

[JITLink] Use rsplit on -sectcreate argument in llvm-jitlink #115511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dgg5503
Copy link
Contributor

@dgg5503 dgg5503 commented Nov 8, 2024

This accounts for cases where the file path may contain an @ symbol. In such cases, the split occurs too early causing argument parsing to fail.

This accounts for cases where the file path may contain an `@` symbol. In
such cases, the split occurs too early causing argument parsing to fail.
@dgg5503
Copy link
Contributor Author

dgg5503 commented Nov 8, 2024

It seems no reviewers were added automatically and I am unable to add reviewers to this PR myself.

Given this is modifying code directly mentioned in 54b014b, I am writing this comment to notify @lhames directly for visibility. May you please review this change or add the appropriate reviewers (if you can) to this PR when you have the chance? Thank you.

Copy link
Contributor

@lhames lhames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @dgg5503.

@lhames lhames merged commit d822c09 into llvm:main Nov 10, 2024
9 checks passed
@dgg5503 dgg5503 deleted the dgliner/main/rsplit-at-symbol-llvm-jitlink branch November 11, 2024 15:24
Groverkss pushed a commit to iree-org/llvm-project that referenced this pull request Nov 15, 2024
…m#115511)

This accounts for cases where the file path may contain an `@` symbol.
In such cases, the split occurs too early causing argument parsing to
fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants