Skip to content

[NFC] Correct imprecise file location in the comment. #115630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2024
Merged

Conversation

c8ef
Copy link
Contributor

@c8ef c8ef commented Nov 10, 2024

No description provided.

@llvmbot llvmbot added the PGO Profile Guided Optimizations label Nov 10, 2024
@c8ef c8ef requested a review from nikic November 10, 2024 03:27
@llvmbot
Copy link
Member

llvmbot commented Nov 10, 2024

@llvm/pr-subscribers-pgo

Author: None (c8ef)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/115630.diff

1 Files Affected:

  • (modified) llvm/include/llvm/ProfileData/CtxInstrContextNode.h (+3-3)
diff --git a/llvm/include/llvm/ProfileData/CtxInstrContextNode.h b/llvm/include/llvm/ProfileData/CtxInstrContextNode.h
index 3b0cbcdd49c254..36a996632b71e3 100644
--- a/llvm/include/llvm/ProfileData/CtxInstrContextNode.h
+++ b/llvm/include/llvm/ProfileData/CtxInstrContextNode.h
@@ -8,9 +8,9 @@
 //==============================================================================
 //
 // NOTE!
-// llvm/lib/ProfileData/CtxInstrContextNode.h and
+// llvm/include/llvm/ProfileData/CtxInstrContextNode.h and
 //   compiler-rt/lib/ctx_profile/CtxInstrContextNode.h
-// must be exact copies of each other
+// must be exact copies of each other.
 //
 // compiler-rt creates these objects as part of the instrumentation runtime for
 // contextual profiling. LLVM only consumes them to convert a contextual tree
@@ -114,4 +114,4 @@ class ContextNode final {
 };
 } // namespace ctx_profile
 } // namespace llvm
-#endif
\ No newline at end of file
+#endif

Copy link
Member

mtrofin commented Nov 10, 2024

Lgtm, but you also need to patch (copy) the corresponding file in compiler_rt. there should be a test failing otherwise, it checks the files are identical.

@c8ef
Copy link
Contributor Author

c8ef commented Nov 10, 2024

Lgtm, but you also need to patch (copy) the corresponding file in compiler_rt. there should be a test failing otherwise, it checks the files are identical.

Oh, I forgot about that. Thanks for reminding me! Now these two files are identical.

@c8ef c8ef requested a review from mtrofin November 10, 2024 04:57
@c8ef c8ef merged commit 59770a4 into llvm:main Nov 10, 2024
9 checks passed
@c8ef c8ef deleted the comment branch November 10, 2024 07:24
Groverkss pushed a commit to iree-org/llvm-project that referenced this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler-rt PGO Profile Guided Optimizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants